Add ObjectRetrierWraps for cinder/nova clients in cinder tests #1170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to how apache2 & haproxy interact on the cinder unit, this adds the ObjectRetrier to the cinder and nova clients to allow for the time delay between the apache2 service starting and the haproxy service noticing and opening the port. This allows the test_100... cinder test to function as (technically) there isn't an error.
These are needed to make the cinder_backup tests more resilient.
openstack-mirroring
pushed a commit
to openstack/charm-cinder-backup
that referenced
this pull request
Jan 11, 2024
Patch out charmhelpers.osplatform.get_platform() and charmhelpers.core.host.lsb_release() globally in the unit tests to insulate the unit tests from the platform that the unit tests are being run on. Change-Id: Ice2a2d2379349c8cf7d77027cbca78b19e9d72d1 func-test-pr: openstack-charmers/zaza-openstack-tests#1170
openstack-mirroring
pushed a commit
to openstack/openstack
that referenced
this pull request
Jan 11, 2024
* Update charm-cinder-backup from branch 'master'
to d00d011c188a69d45368d48f97348cec8c3ea034
- Improve platform mocking
Patch out charmhelpers.osplatform.get_platform() and
charmhelpers.core.host.lsb_release() globally in the unit tests to
insulate the unit tests from the platform that the unit tests are being
run on.
Change-Id: Ice2a2d2379349c8cf7d77027cbca78b19e9d72d1
func-test-pr: openstack-charmers/zaza-openstack-tests#1170
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to how apache2 & haproxy interact on the cinder unit, this adds the
ObjectRetrier to the cinder and nova clients to allow for the time delay
between the apache2 service starting and the haproxy service noticing
and opening the port. This allows the test_100... cinder test to
function as (technically) there isn't an error.