Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tenacity retries around ring sync check [antelope backport] #1152

Merged

Conversation

freyes
Copy link
Member

@freyes freyes commented Oct 12, 2023

This fixes a race when checking if object ring is synced.

(cherry picked from commit 0598ecf)

This fixes a race when checking if object ring is synced.

(cherry picked from commit 0598ecf)
@freyes
Copy link
Member Author

freyes commented Oct 12, 2023

This PR is being exercised by https://review.opendev.org/c/openstack/charm-swift-proxy/+/891549

@freyes freyes requested a review from coreycb October 12, 2023 16:00
Copy link

@coreycb coreycb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, clean backport from master.

@coreycb coreycb merged commit 718ebcd into openstack-charmers:stable/antelope Oct 12, 2023
openstack-mirroring pushed a commit to openstack/charm-swift-proxy that referenced this pull request Oct 12, 2023
…e relation

This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix
any inadvertant accesses of ['ca'] in the relation data before it is available
from vault in the certificates relation.  Fix in charmhelpers is in [1].

[1] juju/charm-helpers#825
Closes-Bug: #2028683

Func-Test-Pr: openstack-charmers/zaza-openstack-tests#1152
Change-Id: Ifbfd7571de866bb4e89a84bef966ae62e8b42410
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants