Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow 401s when checking endpoints #1148

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

gnuoy
Copy link
Contributor

@gnuoy gnuoy commented Oct 5, 2023

Some endpoints (heat) return 401s if you try and access them without authenticating. Given the ep has been able to verify whether you are authenticated a 401 is ok for a rudementary health check

@gnuoy
Copy link
Contributor Author

gnuoy commented Oct 5, 2023

Some endpoints (heat) return 401s if you try and access them
without authenticating. Given the ep has been able to verify
whether you are authenticated a 401 is ok for a rudementary
health check
@gnuoy gnuoy marked this pull request as ready for review October 6, 2023 07:10
Copy link
Contributor

@hemanthnakkina hemanthnakkina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hemanthnakkina hemanthnakkina merged commit 7bd8920 into openstack-charmers:master Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants