(s/antelope) Change skipVersion decorator to a function #1043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Alex, is this still needed? |
coreycb
added
the
stale
The skipVersion decorator was proving to be tricky to use because it took an application name which we didn't want to hard-code, since it is in hacluster/tests.py. One alternative was to pass a charm name instead of application name, but if there were mutiple hacluster applications in the model (e.g. keystone-hacluster and nova-hacluster) we would have to pick just one to test the package version on. After further discussion we decided to change the decorator to a function so that we could use existing class variables to generate the desired hacluster application name. cherry-pick 95fcad2 From PR#1037
ajkavanagh
force-pushed
the
update-skip-version-antelope
branch
from
8507622 to
29ef68f
Compare
ajkavanagh
removed
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The skipVersion decorator was proving to be tricky to use because it took an application name which we didn't want to hard-code, since it is in hacluster/tests.py. One alternative was to pass a charm name instead of application name, but if there were mutiple hacluster applications in the model (e.g. keystone-hacluster and nova-hacluster) we would have to pick just one to test the package version on. After further discussion we decided to change the decorator to a function so that we could use existing class variables to generate the desired hacluster application name.
cherry-pick 95fcad2 From PR#1037