This repository was archived by the owner on Aug 8, 2025. It is now read-only.
Add loadbalancer_annotations config option
#31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabi200123
force-pushed
the
add-loadbalancer-annotations
branch
from
963a1e0 to
bb96258
Compare
|
Can you change the logic to block the charm if annotation is not valid. |
fabi200123
force-pushed
the
add-loadbalancer-annotations
branch
from
bb96258 to
064229b
Compare
fabi200123
force-pushed
the
add-loadbalancer-annotations
branch
from
064229b to
6659eac
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the config option
loadbalancer_annotations, which allows the user to configure a comma-separated list of annotations to apply to the LoadBalancer service to configure the LoadBalancer service inside Kubernetes.