Skip to content

Conversation

@jrvaldes
Copy link
Contributor

This PR adds detection logic to differentiate between OLMv0 and OLMv1 installations
when enabling debug logging for WMCO.

  • OLMv0: Patch subscription and delete deployment to pick up changes
  • OLMv1: Patch deployment directly and scale down/up to apply env vars

This ensures debug logging can be enabled correctly regardless of which
OLM version is managing the operator installation.

Add detection logic to differentiate between OLMv0 and OLMv1 installations
when enabling debug logging for WMCO.

- OLMv0: Patch subscription and delete deployment to pick up changes
- OLMv1: Patch deployment directly and scale down/up to apply env vars

This ensures debug logging can be enabled correctly regardless of which
OLM version is managing the operator installation.
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 12, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 12, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 12, 2026
@jrvaldes
Copy link
Contributor Author

/test ?

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 12, 2026

@jrvaldes: The following commands are available to trigger required jobs:

/test aws-e2e-operator
/test azure-e2e-operator
/test azure-e2e-upgrade
/test ci-bundle-wmco-bundle
/test gcp-e2e-operator
/test images
/test lint
/test nutanix-e2e-operator
/test platform-none-vsphere-e2e-operator
/test security
/test unit
/test vsphere-disconnected-e2e-operator
/test vsphere-e2e-operator
/test vsphere-proxy-e2e-operator
/test wicd-unit-vsphere

Use /test all to run all jobs.

Details

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jrvaldes
Copy link
Contributor Author

/test vsphere-e2e-operator

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 14, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jrvaldes, sebsoto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jrvaldes jrvaldes marked this pull request as ready for review January 14, 2026 14:53
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 14, 2026
@jrvaldes
Copy link
Contributor Author

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 19, 2026

@jrvaldes: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/nutanix-e2e-operator f56fb7a link true /test nutanix-e2e-operator
ci/prow/vsphere-disconnected-e2e-operator f56fb7a link true /test vsphere-disconnected-e2e-operator

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants