-
Notifications
You must be signed in to change notification settings - Fork 74
Add support for OLMv1 when enabling debug logging in e2e test #3694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Add detection logic to differentiate between OLMv0 and OLMv1 installations when enabling debug logging for WMCO. - OLMv0: Patch subscription and delete deployment to pick up changes - OLMv1: Patch deployment directly and scale down/up to apply env vars This ensures debug logging can be enabled correctly regardless of which OLM version is managing the operator installation.
|
Skipping CI for Draft Pull Request. |
|
/test ? |
|
@jrvaldes: The following commands are available to trigger required jobs: Use DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test vsphere-e2e-operator |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jrvaldes, sebsoto The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest-required |
|
@jrvaldes: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This PR adds detection logic to differentiate between OLMv0 and OLMv1 installations
when enabling debug logging for WMCO.
This ensures debug logging can be enabled correctly regardless of which
OLM version is managing the operator installation.