fix the format of output for OCP-13022 #3730
Conversation
| @@ -77,6 +77,6 @@ Feature: Node components upgrade tests | |||
| | cat /etc/kubernetes/kubelet.conf | | |||
| Then the step should succeed | |||
| And the output should contain: | |||
| | "imageMinimumGCAge": "5m0s" | | |||
There was a problem hiding this comment.
Instead of hard code to json/yaml format, we can use the output should match, then we can regexp in the outputs.
| | "imageGCHighThresholdPercent": 80 | | ||
| | "maxPods": 240 | | ||
| And the output should match: | ||
| | [\"]?imageMinimumGCAge[\"]?: [\"]?5m0s[\"]? | |
There was a problem hiding this comment.
I think ["]? is more accurate than ? , means only allow appearing " but no other character
There was a problem hiding this comment.
I think I posted it as "?, not ?
|
/approve |
openshift-ci
bot
added
the
approved
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liangxia The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@lyman9966: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
in 4.17 and 4.18, the kubeletconfig format changed from json to yaml, this pr fix the issue.
Test passed in https://jenkins-csb-openshift-qe-mastern.dno.corp.redhat.com/job/ocp-common/job/Runner/1081067/console