-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Merge qemu & metal tests #939
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: travier The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@travier: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@jlebon: This one failed as it lasted more than 3h |
We could increase the timeout, but I don't think it's a great experience when tests last more than 3h. |
Yeah to really make this sustainable we need to figure out how to get Prow jobs to actually share the ostree-container build. Worst case I think we could do something hacky like push the image to a (separate) registry, and then have the other jobs poll/wait for it. Once we have that, we can "shard" tests as much as we want. For example,
Also, I still think we should get away from running all tests on all builds. We also shouldn't only run the tests on qemu, now that we're in Prow we've always been able to use the Prow cloud credentials to e.g. run tests on AWS/GCP/etc. Splitting off that alone, particularly to use the new |
@travier: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
Rotten issues close after 30d of inactivity. Reopen the issue by commenting /close |
@openshift-bot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Test PR to see how long it takes to run both qemu & metal tests in a single job (would save us a build of RHCOS).
/hold