Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Skip Secure Boot tests for SCOS #1238

Merged
merged 3 commits into from
Apr 5, 2023

Conversation

travier
Copy link
Member

@travier travier commented Apr 4, 2023

ci: Skip Secure Boot tests for SCOS


denylist: Skip Secure Boot tests for SCOS

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 4, 2023
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 4, 2023
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 4, 2023
@travier
Copy link
Member Author

travier commented Apr 4, 2023

Overriding broken RHCOS CI:
/override ci/prow/rhcos-92-build-test-metal
/override ci/prow/rhcos-92-build-test-qemu

This passed the C9S test which is what matters here.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 4, 2023

@travier: Overrode contexts on behalf of travier: ci/prow/rhcos-92-build-test-metal, ci/prow/rhcos-92-build-test-qemu

In response to this:

Overriding broken RHCOS CI:
/override ci/prow/rhcos-92-build-test-metal
/override ci/prow/rhcos-92-build-test-qemu

This passed the C9S test which is what matters here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ci/prow-entrypoint.sh Outdated Show resolved Hide resolved
@travier
Copy link
Member Author

travier commented Apr 4, 2023

Cross linking coreos/coreos-assembler#3418

Comment on lines +29 to +37
- pattern: iso-live-login.uefi-secure
tracker: https://github.com/openshift/os/issues/1237
osversion:
- c9s

- pattern: iso-as-disk.uefi-secure
tracker: https://github.com/openshift/os/issues/1237
osversion:
- c9s
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that could be a single pattern: *.uefi-secure entry. But obviously fine as is too!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. Will be for next time.

@jlebon
Copy link
Member

jlebon commented Apr 4, 2023

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlebon, travier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 4, 2023
@travier
Copy link
Member Author

travier commented Apr 4, 2023

Overriding broken RHCOS CI:
/override ci/prow/rhcos-92-build-test-metal
/override ci/prow/rhcos-92-build-test-qemu

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 4, 2023

@travier: Overrode contexts on behalf of travier: ci/prow/rhcos-92-build-test-metal, ci/prow/rhcos-92-build-test-qemu

In response to this:

Overriding broken RHCOS CI:
/override ci/prow/rhcos-92-build-test-metal
/override ci/prow/rhcos-92-build-test-qemu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cgwalters
Copy link
Member

LGTM though I probably would have said we should pin on a working kernel.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD a051bd8 and 2 for PR HEAD ea46e82 in total

@dustymabe
Copy link
Member

are the CI failures expected?

@travier
Copy link
Member Author

travier commented Apr 5, 2023

The RHCOS CI failures are expected as we are in a mid state with RHEL 9.2.

The SCOS builds should pass. I agree that pinning would have been better but unfortunately C9S kernels are garbage collected quite quickly so that would mean another failure soon.

Thus why I chose to skip the Secure Boot to still let's us test the rest of the kernel for now.

@travier
Copy link
Member Author

travier commented Apr 5, 2023

/override ci/prow/rhcos-92-build-test-metal
/override ci/prow/rhcos-92-build-test-qemu

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 5, 2023

@travier: Overrode contexts on behalf of travier: ci/prow/rhcos-92-build-test-metal, ci/prow/rhcos-92-build-test-qemu

In response to this:

/override ci/prow/rhcos-92-build-test-metal
/override ci/prow/rhcos-92-build-test-qemu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 5, 2023

@travier: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 30413c8 into openshift:master Apr 5, 2023
@travier travier deleted the c9s-skip-sb-tests branch April 5, 2023 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants