-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Skip Secure Boot tests for SCOS #1238
ci: Skip Secure Boot tests for SCOS #1238
Conversation
6f69fab
to
e576ca9
Compare
Overriding broken RHCOS CI: This passed the C9S test which is what matters here. |
@travier: Overrode contexts on behalf of travier: ci/prow/rhcos-92-build-test-metal, ci/prow/rhcos-92-build-test-qemu In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Cross linking coreos/coreos-assembler#3418 |
Keep a distinct directory for test output for each kola run.
897bd59
to
ea46e82
Compare
- pattern: iso-live-login.uefi-secure | ||
tracker: https://github.com/openshift/os/issues/1237 | ||
osversion: | ||
- c9s | ||
|
||
- pattern: iso-as-disk.uefi-secure | ||
tracker: https://github.com/openshift/os/issues/1237 | ||
osversion: | ||
- c9s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that could be a single pattern: *.uefi-secure
entry. But obviously fine as is too!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. Will be for next time.
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlebon, travier The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Overriding broken RHCOS CI: |
@travier: Overrode contexts on behalf of travier: ci/prow/rhcos-92-build-test-metal, ci/prow/rhcos-92-build-test-qemu In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
LGTM though I probably would have said we should pin on a working kernel. |
are the CI failures expected? |
The RHCOS CI failures are expected as we are in a mid state with RHEL 9.2. The SCOS builds should pass. I agree that pinning would have been better but unfortunately C9S kernels are garbage collected quite quickly so that would mean another failure soon. Thus why I chose to skip the Secure Boot to still let's us test the rest of the kernel for now. |
/override ci/prow/rhcos-92-build-test-metal |
@travier: Overrode contexts on behalf of travier: ci/prow/rhcos-92-build-test-metal, ci/prow/rhcos-92-build-test-qemu In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@travier: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
ci: Skip Secure Boot tests for SCOS
denylist: Skip Secure Boot tests for SCOS