Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-42044: Minimize git-clone Privileges #29106

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

adambkaplan
Copy link
Contributor

As part of the mitigation for CVE-2024-45496, the git-clone container for builds was updated to run unprivileged and a minimal set of Linux capabilities enabled. This update ensures that we do not regress and elevate the permissions granted to the git-clone container in builds.

As part of the mitigation for CVE-2024-45496, the `git-clone` container
for builds was updated to run unprivileged and a minimal set of Linux
capabilities enabled. This update ensures that we do not regress and
elevate the permissions granted to the `git-clone` container in builds.

Signed-off-by: Adam Kaplan <[email protected]>
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Sep 16, 2024
@openshift-ci-robot
Copy link

@adambkaplan: This pull request references Jira Issue OCPBUGS-42044, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jitendar-singh

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

As part of the mitigation for CVE-2024-45496, the git-clone container for builds was updated to run unprivileged and a minimal set of Linux capabilities enabled. This update ensures that we do not regress and elevate the permissions granted to the git-clone container in builds.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@deads2k
Copy link
Contributor

deads2k commented Sep 16, 2024

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 16, 2024
@adambkaplan
Copy link
Contributor Author

/cherrypick release-4.17,release-4.16,release-4.15,release-4.14,release-4.13,release-4.12

@openshift-cherrypick-robot

@adambkaplan: once the present PR merges, I will cherry-pick it on top of release-4.17,release-4.16,release-4.15,release-4.14,release-4.13,release-4.12 in a new PR and assign it to you.

In response to this:

/cherrypick release-4.17,release-4.16,release-4.15,release-4.14,release-4.13,release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sayan-biswas
Copy link

/approve

Copy link
Contributor

openshift-ci bot commented Sep 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, deads2k, sayan-biswas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sayan-biswas
Copy link

/test e2e-gcp-ovn-builds

@adambkaplan
Copy link
Contributor Author

Note - this might need another re-test. The commit with the patch was not added to our public repo until this morning (after I pushed the test fix commit).

@adambkaplan
Copy link
Contributor Author

/retest

Test ran before the patches were made public.

@adambkaplan
Copy link
Contributor Author

/retest

Copy link
Contributor

openshift-ci bot commented Oct 12, 2024

@adambkaplan: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node-upgrade 56e238b link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-gcp-ovn-builds 56e238b link true /test e2e-gcp-ovn-builds
ci/prow/e2e-aws-ovn-ipsec-serial 56e238b link false /test e2e-aws-ovn-ipsec-serial

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-trt-bot
Copy link

Job Failure Risk Analysis for sha: 56e238b

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-upgrade Medium
[bz-kube-apiserver][invariant] alert/KubeAPIErrorBudgetBurn should not be at or above info
This test has passed 89.89% of 178 runs on release 4.18 [Architecture:amd64 FeatureSet:default Installer:ipi Network:ovn NetworkStack:ipv4 Platform:aws SecurityMode:default Topology:single Upgrade:micro] in the last week.

Open Bugs
SNO error rate for alert/KubeAPIErrorBudgetBurn should not be at or above info
alert/KubeAPIErrorBudgetBurn should not be at or above info
alert/KubeAPIErrorBudgetBurn should not be at or above info

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants