Skip to content

Commit

Permalink
cert tests: make TLS registry tests required
Browse files Browse the repository at this point in the history
  • Loading branch information
vrutkovs committed Sep 19, 2024
1 parent 3e73283 commit a26084a
Showing 1 changed file with 3 additions and 9 deletions.
12 changes: 3 additions & 9 deletions test/extended/operators/certs.go
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ import (

"github.com/openshift/origin/pkg/certs"
"github.com/openshift/origin/pkg/monitortestlibrary/platformidentification"
testresult "github.com/openshift/origin/pkg/test/ginkgo/result"
exutil "github.com/openshift/origin/test/extended/util"
"github.com/openshift/origin/test/extended/util/image"
ownership "github.com/openshift/origin/tls"
Expand Down Expand Up @@ -262,12 +261,9 @@ var _ = g.Describe(fmt.Sprintf("[sig-arch][Late][Jira:%q]", "kube-apiserver"), g
if len(newTLSRegistry.CertKeyPairs) > 0 || len(newTLSRegistry.CertificateAuthorityBundles) > 0 {
registryString, err := json.MarshalIndent(newTLSRegistry, "", " ")
if err != nil {
//g.Fail("Failed to marshal registry %#v: %v", newTLSRegistry, err)
testresult.Flakef("Failed to marshal registry %#v: %v", newTLSRegistry, err)
g.Fail(fmt.Sprintf("Failed to marshal registry %#v: %v", newTLSRegistry, err))
}
// TODO: uncomment when test no longer fails and enhancement is merged
//g.Fail(fmt.Sprintf("Unregistered TLS certificates:\n%s", registryString))
testresult.Flakef(fmt.Sprintf("Unregistered TLS certificates found:\n%s\nSee tls/ownership/README.md in origin repo", registryString))
g.Fail(fmt.Sprintf("Unregistered TLS certificates:\n%s\nSee tls/ownership/README.md in origin repo", registryString))
}
})

Expand All @@ -277,9 +273,7 @@ var _ = g.Describe(fmt.Sprintf("[sig-arch][Late][Jira:%q]", "kube-apiserver"), g
o.Expect(err).NotTo(o.HaveOccurred())

if len(messages) > 0 {
// TODO: uncomment when test no longer fails and enhancement is merged
//g.Fail(strings.Join(messages, "\n"))
testresult.Flakef(strings.Join(messages, "\n"))
g.Fail(strings.Join(messages, "\n"))
}
})

Expand Down

0 comments on commit a26084a

Please sign in to comment.