NO-JIRA: only save graph data if it's valid json

[r4f4]

Description

• If we save the graph data to disk before checking it's valid, we can run into unmarshaling errors later like:

  2025/02/05 02:14:36  [ERROR]  : [GetReleaseReferenceImages] error list [APIRequestError: channel "stable-4.16": ResponseInvalid: invalid character 'a' after top-level value]
  

• Just returning unmarshaling errors is not very useful information:

  ResponseInvalid: invalid character 'a' after top-level value
  

  Let's add more context to that error when reading graph data from the
  working dir so we know which is the offending file.

Github / Jira issue:

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Code Improvements (Refactoring, Performance, CI upgrades, etc)
• Internal repo assets (diagrams / docs on github repo)
• This change requires a documentation update on openshift docs

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

Expected Outcome

Please describe the outcome expected from the tests.

[openshift-ci]

@r4f4: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[sherine-k]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: r4f4, sherine-k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [sherine-k]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[lmzuccarelli]

/label acknowledge-critical-fixes-only

[lmzuccarelli]

/retitle NO-JIRA: only save graph data if it's valid json

[openshift-ci-robot]

@r4f4: This pull request explicitly references no jira issue.

In response to this:

Description

• If we save the graph data to disk before checking it's valid, we can run into unmarshaling errors later like:

  2025/02/05 02:14:36  [ERROR]  : [GetReleaseReferenceImages] error list [APIRequestError: channel "stable-4.16": ResponseInvalid: invalid character 'a' after top-level value]
  

• Just returning unmarshaling errors is not very useful information:

  ResponseInvalid: invalid character 'a' after top-level value
  

  Let's add more context to that error when reading graph data from the
  working dir so we know which is the offending file.

Github / Jira issue:

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Code Improvements (Refactoring, Performance, CI upgrades, etc)
• Internal repo assets (diagrams / docs on github repo)
• This change requires a documentation update on openshift docs

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

Expected Outcome

Please describe the outcome expected from the tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.