[oadp-1.5]OCPBUGS-68338: Add audit annotations and unified pause/unpause logic for Hypershift backup operations #176

jparrill · 2025-12-15T11:51:33Z

What this PR does / why we need it

Manual backport of OCPBUGS-66146: Add audit annotations and unified pause/unpause logic for Hypershift backup operations #170

Which issue(s) this PR fixes

- Add audit annotation constants for tracking pause operations - Implement atomic annotation management (add on pause, remove on unpause) - Unify UpdateHostedCluster and UpdateNodepools with shared logic - Add progress-based pause/unpause: >1% pause, >90% unpause - Implement LAST MILE safety net for guaranteed resource cleanup - Fix data mover validation to only execute when defined in backup - Add comprehensive unit tests for new functionality - Fix validation tests with snapshotMoveData factor 🚀 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]> Signed-off-by: Juan Manuel Parrilla Madrid <[email protected]>

- Update hypershift/api dependency to latest version - Update associated Go dependencies and vendor files 🚀 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]> Signed-off-by: Juan Manuel Parrilla Madrid <[email protected]>

[Slack Thread](https://redhat-internal.slack.com/archives/C0144ECKUJ0/p1765210917204249?thread_ts=1764855853.186139&cid=C0144ECKUJ0)

coderabbitai · 2025-12-15T11:51:39Z

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)

do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

openshift-ci-robot · 2025-12-15T11:51:40Z

@jparrill: This pull request references Jira Issue OCPBUGS-66146, which is invalid:

release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
expected Jira Issue OCPBUGS-66146 to depend on a bug in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

What this PR does / why we need it

Manual backport of OCPBUGS-66146: Add audit annotations and unified pause/unpause logic for Hypershift backup operations #170

Which issue(s) this PR fixes

Fixes #

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

jparrill · 2025-12-15T11:51:57Z

/jira cherrypick OCPBUGS-66146

openshift-ci · 2025-12-15T11:52:01Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jparrill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [jparrill]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2025-12-15T11:52:01Z

@jparrill: Could not make automatic cherrypick of Jira Issue OCPBUGS-66146 for this PR as the target version is not set for this branch in the jira plugin config. Running refresh:
/jira refresh

/retitle : [oadp-1.5] OCPBUGS-66146: Add audit annotations and unified pause/unpause logic for Hypershift backup operations

Details

In response to this:

/jira cherrypick OCPBUGS-66146

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2025-12-15T11:52:05Z

@openshift-ci-robot: This pull request references Jira Issue OCPBUGS-66146, which is invalid:

release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
expected Jira Issue OCPBUGS-66146 to depend on a bug in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

@jparrill: Could not make automatic cherrypick of Jira Issue OCPBUGS-66146 for this PR as the target version is not set for this branch in the jira plugin config. Running refresh:
/jira refresh

/retitle : [oadp-1.5] OCPBUGS-66146: Add audit annotations and unified pause/unpause logic for Hypershift backup operations

In response to this:

/jira cherrypick OCPBUGS-66146

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2025-12-15T11:55:29Z

@jparrill: This pull request references Jira Issue OCPBUGS-68338, which is invalid:

release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
expected dependent Jira Issue OCPBUGS-66146 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

What this PR does / why we need it

Manual backport of OCPBUGS-66146: Add audit annotations and unified pause/unpause logic for Hypershift backup operations #170

Which issue(s) this PR fixes

Fixes #OCPBUGS-68338

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

jparrill · 2025-12-15T11:56:36Z

/jira refresh

openshift-ci-robot · 2025-12-15T11:56:40Z

@jparrill: This pull request references Jira Issue OCPBUGS-68338, which is invalid:

expected dependent Jira Issue OCPBUGS-66146 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2025-12-15T12:03:25Z

@jparrill: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

mgencur · 2025-12-16T08:40:12Z

/lgtm

jparrill · 2025-12-16T21:03:18Z

/jira refresh

openshift-ci-robot · 2025-12-16T21:03:22Z

@jparrill: This pull request references Jira Issue OCPBUGS-68338, which is invalid:

expected dependent Jira Issue OCPBUGS-66146 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

jparrill · 2025-12-19T09:10:26Z

/jira refresh

openshift-ci-robot · 2025-12-19T09:10:30Z

@jparrill: This pull request references Jira Issue OCPBUGS-68338, which is invalid:

expected dependent Jira Issue OCPBUGS-66146 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

jparrill and others added 3 commits December 15, 2025 12:46

Update RPMs lockfile

0182f49

[Slack Thread](https://redhat-internal.slack.com/archives/C0144ECKUJ0/p1765210917204249?thread_ts=1764855853.186139&cid=C0144ECKUJ0)

openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Dec 15, 2025

openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Dec 15, 2025

openshift-ci bot requested review from devguyio and kaovilai December 15, 2025 11:52

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 15, 2025

openshift-ci bot changed the title ~~[oadp-1.5] OCPBUGS-66146: Add audit annotations and unified pause/unpause logic for Hypershift backup operations~~ : [oadp-1.5] OCPBUGS-66146: Add audit annotations and unified pause/unpause logic for Hypershift backup operations Dec 15, 2025

jparrill changed the title ~~: [oadp-1.5] OCPBUGS-66146: Add audit annotations and unified pause/unpause logic for Hypershift backup operations~~ [oadp-1.5] OCPBUGS-66146: Add audit annotations and unified pause/unpause logic for Hypershift backup operations Dec 15, 2025

jparrill changed the title ~~[oadp-1.5] OCPBUGS-66146: Add audit annotations and unified pause/unpause logic for Hypershift backup operations~~ [oadp-1.5]OCPBUGS-68338: Add audit annotations and unified pause/unpause logic for Hypershift backup operations Dec 15, 2025

openshift-ci bot assigned mgencur Dec 16, 2025

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 16, 2025

openshift-ci-robot mentioned this pull request Dec 16, 2025

OCPBUGS-66146: Add OADP backup recovery tool for HyperShift clusters openshift/hypershift#7385

Merged

6 tasks

[oadp-1.5]OCPBUGS-68338: Add audit annotations and unified pause/unpause logic for Hypershift backup operations #176

Are you sure you want to change the base?

[oadp-1.5]OCPBUGS-68338: Add audit annotations and unified pause/unpause logic for Hypershift backup operations #176

Uh oh!

Conversation

jparrill commented Dec 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What this PR does / why we need it

Which issue(s) this PR fixes

Uh oh!

coderabbitai bot commented Dec 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

openshift-ci-robot commented Dec 15, 2025

What this PR does / why we need it

Which issue(s) this PR fixes

Uh oh!

jparrill commented Dec 15, 2025

Uh oh!

openshift-ci bot commented Dec 15, 2025

Uh oh!

openshift-ci-robot commented Dec 15, 2025

Uh oh!

openshift-ci-robot commented Dec 15, 2025

Uh oh!

openshift-ci-robot commented Dec 15, 2025

What this PR does / why we need it

Which issue(s) this PR fixes

Uh oh!

jparrill commented Dec 15, 2025

Uh oh!

openshift-ci-robot commented Dec 15, 2025

Uh oh!

openshift-ci bot commented Dec 15, 2025

Uh oh!

mgencur commented Dec 16, 2025

Uh oh!

jparrill commented Dec 16, 2025

Uh oh!

openshift-ci-robot commented Dec 16, 2025

Uh oh!

jparrill commented Dec 19, 2025

Uh oh!

openshift-ci-robot commented Dec 19, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jparrill commented Dec 15, 2025 •

edited

Loading

coderabbitai bot commented Dec 15, 2025 •

edited

Loading