Skip to content

move part of qe cases in openshift-tests-private to cvo #1226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

move part of qe cases in openshift-tests-private to cvo #1226

wants to merge 1 commit into from
+729,585 −10

Conversation

jiajliu
Copy link

@jiajliu jiajliu commented Sep 2, 2025 •
edited
Loading

To start with OTE, this pr is to make e2e tests included in cvo repo and executed with OTE (only picking up parallel cases as a small set for exploration).

  • Add initTest for test initialization in OTE
  • Move cvo’s cases which can be executed in parallel from openshift-tests-private repository to cvo
  • Copy required utils and resolve dependencies

Test result locally:

$ hack/build-go.sh
Using version from git...
Building binaries into _output/linux/amd64
Building github.com/openshift/cluster-version-operator cluster-version-operator-tests binary (v1.0.0-1459-g9de00ba8-dirty)
Compressing the cluster-version-operator-tests binary
Building github.com/openshift/cluster-version-operator cluster-version-operator binary (v1.0.0-1459-g9de00ba8-dirty)

$ _output/linux/amd64/cluster-version-operator-tests run-suite cvo/parallel > /tmp/test.log 2>&1
$

$ cat /tmp/test.log|grep -A5 "\"\[cvo.testing\]"
    "name": "[cvo-testing] cluster-version-operator-tests should support passing tests",
    "lifecycle": "blocking",
    "duration": 1,
    "startTime": "2025-09-02 03:35:36.412577 UTC",
    "endTime": "2025-09-02 03:35:36.414139 UTC",
    "result": "passed",
--
    "name": "[cvo-testing] cluster-version-operator-tests Author:jiajliu-Medium-47198-Techpreview operator will not be installed on a fresh installed cluster",
    "lifecycle": "blocking",
    "duration": 34544,
    "startTime": "2025-09-02 03:35:36.412596 UTC",
    "endTime": "2025-09-02 03:36:10.957353 UTC",
    "result": "passed",
--
    "name": "[cvo-testing] cluster-version-operator-tests Author:dis-High-56072-CVO pod should not crash",
    "lifecycle": "blocking",
    "duration": 36682,
    "startTime": "2025-09-02 03:35:36.412605 UTC",
    "endTime": "2025-09-02 03:36:13.095046 UTC",
    "result": "passed",
--
    "name": "[cvo-testing] cluster-version-operator-tests Author:jiajliu-Medium-53906-The architecture info in clusterversion’s status should be correct",
    "lifecycle": "blocking",
    "duration": 45608,
    "startTime": "2025-09-02 03:35:36.412607 UTC",
    "endTime": "2025-09-02 03:36:22.021023 UTC",
    "result": "passed",
--
    "name": "[cvo-testing] cluster-version-operator-tests Author:jiajliu-Low-46922-check runlevel in cvo ns",
    "lifecycle": "blocking",
    "duration": 48469,
    "startTime": "2025-09-02 03:35:36.412610 UTC",
    "endTime": "2025-09-02 03:36:24.882338 UTC",
    "result": "passed",
--
    "name": "[cvo-testing] cluster-version-operator-tests Author:dis-Low-49670-change spec.capabilities to invalid value",
    "lifecycle": "blocking",
    "duration": 56089,
    "startTime": "2025-09-02 03:35:36.412613 UTC",
    "endTime": "2025-09-02 03:36:32.502304 UTC",
    "result": "passed",
--
    "name": "[cvo-testing] cluster-version-operator-tests Author:dis-Medium-41391-cvo serves metrics over only https not http",
    "lifecycle": "blocking",
    "duration": 71401,
    "startTime": "2025-09-02 03:35:36.412614 UTC",
    "endTime": "2025-09-02 03:36:47.814365 UTC",
    "result": "failed",
--
    "name": "[cvo-testing] cluster-version-operator-tests Author:jianl-High-42543-the removed resources are not created in a fresh installed cluster",
    "lifecycle": "blocking",
    "duration": 106739,
    "startTime": "2025-09-02 03:35:36.412616 UTC",
    "endTime": "2025-09-02 03:37:23.151732 UTC",
    "result": "passed",

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 2, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jiajliu
Once this PR has been reviewed and has the lgtm label, please assign hongkailiu for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jiajliu jiajliu force-pushed the migrate branch 2 times, most recently from a358f4c to 6fc02b9 Compare September 2, 2025 04:21
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 2, 2025

@jiajliu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify-update dbc8959 link true /test verify-update
ci/prow/e2e-aws-ovn-techpreview dbc8959 link true /test e2e-aws-ovn-techpreview

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@dis016
Copy link

dis016 commented Sep 12, 2025

🤖 AI Code Review Summary

Overall Score: 60/100

🔴 NEEDS WORK - Several issues should be addressed

💡 Key Recommendations:

  • Consider breaking this large PR into smaller, focused changes
  • Large code addition - ensure thorough testing and documentation

Generated by AI Code Review Assistant

1 similar comment
@dis016
Copy link

dis016 commented Sep 12, 2025

🤖 AI Code Review Summary

Overall Score: 60/100

🔴 NEEDS WORK - Several issues should be addressed

💡 Key Recommendations:

  • Consider breaking this large PR into smaller, focused changes
  • Large code addition - ensure thorough testing and documentation

Generated by AI Code Review Assistant

@dis016
Copy link

dis016 commented Sep 12, 2025

🤖 AI Code Review Summary

Overall Score: 60/100

🔴 NEEDS WORK - Several issues should be addressed

💡 Key Recommendations:

  • Consider breaking this large PR into smaller, focused changes
  • Large code addition - ensure thorough testing and documentation

Generated by AI Code Review Assistant

@dis016
Copy link

dis016 commented Sep 12, 2025

🤖 AI Code Review Summary

Overall Score: 60/100

🔴 NEEDS WORK - Several issues should be addressed

💡 Key Recommendations:

  • Consider breaking this large PR into smaller, focused changes
  • Large code addition - ensure thorough testing and documentation

Generated by AI Code Review Assistant

@dis016
Copy link

dis016 commented Sep 12, 2025

🤖 AI Code Review Summary

Overall Score: 60/100

🔴 NEEDS WORK - Several issues should be addressed

💡 Key Recommendations:

  • Consider breaking this large PR into smaller, focused changes
  • Large code addition - ensure thorough testing and documentation

Generated by AI Code Review Assistant

@dis016
Copy link

dis016 commented Sep 12, 2025

🤖 AI Code Review Summary

Overall Score: 60/100

🔴 NEEDS WORK - Several issues should be addressed

💡 Key Recommendations:

  • Consider breaking this large PR into smaller, focused changes
  • Large code addition - ensure thorough testing and documentation

📄 File-by-File Analysis:

test/cvo/util.go

  • 🟡 [Minor] New Go file without corresponding test file

test/util/assert.go

  • 🟡 [Minor] New Go file without corresponding test file

test/util/client.go

  • 🟡 [Minor] New Go file without corresponding test file

test/util/clusters.go

  • 🟡 [Minor] New Go file without corresponding test file

test/util/framework.go

  • 🟡 [Minor] New Go file without corresponding test file

test/util/test.go

  • 🟡 [Minor] New Go file without corresponding test file

vendor/github.com/JeffAshton/win_pdh/pdh.go

  • 🟡 [Minor] New Go file without corresponding test file

vendor/github.com/Microsoft/go-winio/backup.go

  • 🟡 [Minor] New Go file without corresponding test file

vendor/github.com/Microsoft/go-winio/doc.go

  • 🟡 [Minor] New Go file without corresponding test file

vendor/github.com/Microsoft/go-winio/ea.go

  • 🟡 [Minor] New Go file without corresponding test file

vendor/github.com/Microsoft/go-winio/file.go

  • 🟡 [Minor] New Go file without corresponding test file

vendor/github.com/Microsoft/go-winio/fileinfo.go

  • 🟡 [Minor] New Go file without corresponding test file

vendor/github.com/Microsoft/go-winio/hvsock.go

  • ⚠️ [Major] Large file addition - consider breaking into smaller changes
  • 🟡 [Minor] New Go file without corresponding test file

vendor/github.com/Microsoft/go-winio/internal/fs/doc.go

  • 🟡 [Minor] New Go file without corresponding test file

vendor/github.com/Microsoft/go-winio/internal/fs/fs.go

  • 🟡 [Minor] New Go file without corresponding test file

vendor/github.com/Microsoft/go-winio/internal/fs/security.go

  • 🟡 [Minor] New Go file without corresponding test file

Generated by AI Code Review Assistant

3 similar comments
@dis016
Copy link

dis016 commented Sep 13, 2025

🤖 AI Code Review Summary

Overall Score: 60/100

🔴 NEEDS WORK - Several issues should be addressed

💡 Key Recommendations:

  • Consider breaking this large PR into smaller, focused changes
  • Large code addition - ensure thorough testing and documentation

📄 File-by-File Analysis:

test/cvo/util.go

  • 🟡 [Minor] New Go file without corresponding test file

test/util/assert.go

  • 🟡 [Minor] New Go file without corresponding test file

test/util/client.go

  • 🟡 [Minor] New Go file without corresponding test file

test/util/clusters.go

  • 🟡 [Minor] New Go file without corresponding test file

test/util/framework.go

  • 🟡 [Minor] New Go file without corresponding test file

test/util/test.go

  • 🟡 [Minor] New Go file without corresponding test file

vendor/github.com/JeffAshton/win_pdh/pdh.go

  • 🟡 [Minor] New Go file without corresponding test file

vendor/github.com/Microsoft/go-winio/backup.go

  • 🟡 [Minor] New Go file without corresponding test file

vendor/github.com/Microsoft/go-winio/doc.go

  • 🟡 [Minor] New Go file without corresponding test file

vendor/github.com/Microsoft/go-winio/ea.go

  • 🟡 [Minor] New Go file without corresponding test file

vendor/github.com/Microsoft/go-winio/file.go

  • 🟡 [Minor] New Go file without corresponding test file

vendor/github.com/Microsoft/go-winio/fileinfo.go

  • 🟡 [Minor] New Go file without corresponding test file

vendor/github.com/Microsoft/go-winio/hvsock.go

  • ⚠️ [Major] Large file addition - consider breaking into smaller changes
  • 🟡 [Minor] New Go file without corresponding test file

vendor/github.com/Microsoft/go-winio/internal/fs/doc.go

  • 🟡 [Minor] New Go file without corresponding test file

vendor/github.com/Microsoft/go-winio/internal/fs/fs.go

  • 🟡 [Minor] New Go file without corresponding test file

vendor/github.com/Microsoft/go-winio/internal/fs/security.go

  • 🟡 [Minor] New Go file without corresponding test file

Generated by AI Code Review Assistant

@dis016
Copy link

dis016 commented Sep 15, 2025

🤖 AI Code Review Summary

Overall Score: 60/100

🔴 NEEDS WORK - Several issues should be addressed

💡 Key Recommendations:

  • Consider breaking this large PR into smaller, focused changes
  • Large code addition - ensure thorough testing and documentation

📄 File-by-File Analysis:

test/cvo/util.go

  • 🟡 [Minor] New Go file without corresponding test file

test/util/assert.go

  • 🟡 [Minor] New Go file without corresponding test file

test/util/client.go

  • 🟡 [Minor] New Go file without corresponding test file

test/util/clusters.go

  • 🟡 [Minor] New Go file without corresponding test file

test/util/framework.go

  • 🟡 [Minor] New Go file without corresponding test file

test/util/test.go

  • 🟡 [Minor] New Go file without corresponding test file

vendor/github.com/JeffAshton/win_pdh/pdh.go

  • 🟡 [Minor] New Go file without corresponding test file

vendor/github.com/Microsoft/go-winio/backup.go

  • 🟡 [Minor] New Go file without corresponding test file

vendor/github.com/Microsoft/go-winio/doc.go

  • 🟡 [Minor] New Go file without corresponding test file

vendor/github.com/Microsoft/go-winio/ea.go

  • 🟡 [Minor] New Go file without corresponding test file

vendor/github.com/Microsoft/go-winio/file.go

  • 🟡 [Minor] New Go file without corresponding test file

vendor/github.com/Microsoft/go-winio/fileinfo.go

  • 🟡 [Minor] New Go file without corresponding test file

vendor/github.com/Microsoft/go-winio/hvsock.go

  • ⚠️ [Major] Large file addition - consider breaking into smaller changes
  • 🟡 [Minor] New Go file without corresponding test file

vendor/github.com/Microsoft/go-winio/internal/fs/doc.go

  • 🟡 [Minor] New Go file without corresponding test file

vendor/github.com/Microsoft/go-winio/internal/fs/fs.go

  • 🟡 [Minor] New Go file without corresponding test file

vendor/github.com/Microsoft/go-winio/internal/fs/security.go

  • 🟡 [Minor] New Go file without corresponding test file

Generated by AI Code Review Assistant

@dis016
Copy link

dis016 commented Sep 15, 2025

🤖 AI Code Review Summary

Overall Score: 60/100

🔴 NEEDS WORK - Several issues should be addressed

💡 Key Recommendations:

  • Consider breaking this large PR into smaller, focused changes
  • Large code addition - ensure thorough testing and documentation

📄 File-by-File Analysis:

test/cvo/util.go

  • 🟡 [Minor] New Go file without corresponding test file

test/util/assert.go

  • 🟡 [Minor] New Go file without corresponding test file

test/util/client.go

  • 🟡 [Minor] New Go file without corresponding test file

test/util/clusters.go

  • 🟡 [Minor] New Go file without corresponding test file

test/util/framework.go

  • 🟡 [Minor] New Go file without corresponding test file

test/util/test.go

  • 🟡 [Minor] New Go file without corresponding test file

vendor/github.com/JeffAshton/win_pdh/pdh.go

  • 🟡 [Minor] New Go file without corresponding test file

vendor/github.com/Microsoft/go-winio/backup.go

  • 🟡 [Minor] New Go file without corresponding test file

vendor/github.com/Microsoft/go-winio/doc.go

  • 🟡 [Minor] New Go file without corresponding test file

vendor/github.com/Microsoft/go-winio/ea.go

  • 🟡 [Minor] New Go file without corresponding test file

vendor/github.com/Microsoft/go-winio/file.go

  • 🟡 [Minor] New Go file without corresponding test file

vendor/github.com/Microsoft/go-winio/fileinfo.go

  • 🟡 [Minor] New Go file without corresponding test file

vendor/github.com/Microsoft/go-winio/hvsock.go

  • ⚠️ [Major] Large file addition - consider breaking into smaller changes
  • 🟡 [Minor] New Go file without corresponding test file

vendor/github.com/Microsoft/go-winio/internal/fs/doc.go

  • 🟡 [Minor] New Go file without corresponding test file

vendor/github.com/Microsoft/go-winio/internal/fs/fs.go

  • 🟡 [Minor] New Go file without corresponding test file

vendor/github.com/Microsoft/go-winio/internal/fs/security.go

  • 🟡 [Minor] New Go file without corresponding test file

Generated by AI Code Review Assistant

@dis016
Copy link

dis016 commented Sep 15, 2025

🤖 AI Code Review Summary

Overall Score: 60/100

🔴 NEEDS WORK - Several issues should be addressed

💡 Key Recommendations:

  • Consider breaking this large PR into smaller, focused changes
  • Large code addition - ensure thorough testing and documentation

Generated by AI Code Review Assistant

@dis016
Copy link

dis016 commented Sep 15, 2025

🤖 AI Code Review Summary

Overall Score: 60/100

🔴 NEEDS WORK - Several issues should be addressed

💡 Key Recommendations:

  • Consider breaking this large PR into smaller, focused changes
  • Large code addition - ensure thorough testing and documentation

📄 File-by-File Analysis:

test/cvo/util.go

  • 🟡 [Minor] New Go file without corresponding test file

test/util/assert.go

  • 🟡 [Minor] New Go file without corresponding test file

test/util/client.go

  • 🟡 [Minor] New Go file without corresponding test file

test/util/clusters.go

  • 🟡 [Minor] New Go file without corresponding test file

test/util/framework.go

  • 🟡 [Minor] New Go file without corresponding test file

test/util/test.go

  • 🟡 [Minor] New Go file without corresponding test file

vendor/github.com/JeffAshton/win_pdh/pdh.go

  • 🟡 [Minor] New Go file without corresponding test file

vendor/github.com/Microsoft/go-winio/backup.go

  • 🟡 [Minor] New Go file without corresponding test file

vendor/github.com/Microsoft/go-winio/doc.go

  • 🟡 [Minor] New Go file without corresponding test file

vendor/github.com/Microsoft/go-winio/ea.go

  • 🟡 [Minor] New Go file without corresponding test file

vendor/github.com/Microsoft/go-winio/file.go

  • 🟡 [Minor] New Go file without corresponding test file

vendor/github.com/Microsoft/go-winio/fileinfo.go

  • 🟡 [Minor] New Go file without corresponding test file

vendor/github.com/Microsoft/go-winio/hvsock.go

  • ⚠️ [Major] Large file addition - consider breaking into smaller changes
  • 🟡 [Minor] New Go file without corresponding test file

vendor/github.com/Microsoft/go-winio/internal/fs/doc.go

  • 🟡 [Minor] New Go file without corresponding test file

vendor/github.com/Microsoft/go-winio/internal/fs/fs.go

  • 🟡 [Minor] New Go file without corresponding test file

vendor/github.com/Microsoft/go-winio/internal/fs/security.go

  • 🟡 [Minor] New Go file without corresponding test file

Generated by AI Code Review Assistant

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jiajliu @dis016