Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OTA-209: Bump github.com/openshift/api #1130

Conversation

DavidHurta
Copy link
Contributor

Steps:

$ go get github.com/openshift/api
$ go mod tidy
$ go mod vendor
$ go mod verify

So that we can use the new ClusterVersionOperator API.

Steps:
```
$ go get github.com/openshift/api
$ go mod tidy
$ go mod vendor
$ go mod verify
```
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 17, 2024

@DavidHurta: This pull request references OTA-209 which is a valid jira issue.

In response to this:

Steps:

$ go get github.com/openshift/api
$ go mod tidy
$ go mod vendor
$ go mod verify

So that we can use the new ClusterVersionOperator API.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 17, 2024
@openshift-ci openshift-ci bot requested review from petr-muller and wking December 17, 2024 13:24
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 17, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 17, 2024
Copy link
Contributor

openshift-ci bot commented Dec 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DavidHurta, petr-muller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [DavidHurta,petr-muller]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@DavidHurta
Copy link
Contributor Author

/retest-required

1 similar comment
@DavidHurta
Copy link
Contributor Author

/retest-required

@DavidHurta
Copy link
Contributor Author

/retest

@DavidHurta
Copy link
Contributor Author

/label no-qe

Labeling as no additional pre-merge testing by QE is required. This is a simple minor github.com/openshift/api bumb. The CI should be plenty to check for any potential regression.

@openshift-ci openshift-ci bot added the no-qe Allows PRs to merge without qe-approved label label Dec 18, 2024
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD d510bfd and 2 for PR HEAD c84c3fc in total

1 similar comment
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD d510bfd and 2 for PR HEAD c84c3fc in total

Copy link
Contributor

openshift-ci bot commented Dec 18, 2024

@DavidHurta: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn c84c3fc link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD d510bfd and 2 for PR HEAD c84c3fc in total

@openshift-merge-bot openshift-merge-bot bot merged commit e90705b into openshift:main Jan 6, 2025
13 of 14 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: cluster-version-operator
This PR has been included in build cluster-version-operator-container-v4.19.0-202501070436.p0.ge90705b.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. no-qe Allows PRs to merge without qe-approved label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants