siteconfig: add WaitForExtraLabel method to CIBuilder #907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klaskosk
requested review from
kononovn,
trewest,
achuzhoy and
cdvultur
as code owners
kononovn
reviewed
Feb 3, 2025
| if valid, err := builder.validate(); !valid { | ||
| return nil, err | ||
| } | ||
|
|
There was a problem hiding this comment.
Please add informative glog message.
There was a problem hiding this comment.
@kononovn Thanks, I've added a glog message (and to my other PR)
When provisioning clusters using oran, the ClusterInstance is managed by the oran-o2ims operator. It is useful to wait for changes to the ExtraLabels field to be propogated to the ClusterInstance by the operator, something the WaitForExtraLabel method allows.
klaskosk
force-pushed
the
ci-wait-for-label
branch
from
9db8841 to
ed3e6ac
Compare
sebrandon1
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When provisioning clusters using oran, the ClusterInstance is managed by the oran-o2ims operator. It is useful to wait for changes to the ExtraLabels field to be propogated to the ClusterInstance by the operator, something the WaitForExtraLabel method allows.