Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infra: CNF-14990: Replace abandoned gimme tool & Provide alignment for golang version #2073

Merged

Conversation

fontivan
Copy link
Contributor

  • Since golang 1.21, go is much better at managing its own version requirements (https://go.dev/doc/toolchain)
  • The gimme tool seems to be abandoned and does not work correctly for modern go versions (gimme stable does not work for latest Go (v1.21.0) travis-ci/gimme#210)
  • Designate the top level go.mod as the source of truth for the go version in the project
  • Includes notes on where this version needs to be updated to match
  • Update fedora image used in ci job to fedora 40 since it provides golang 1.22 in its repos

@openshift-ci-robot
Copy link
Collaborator

@fontivan: This pull request references CNF-14990 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

  • Since golang 1.21, go is much better at managing its own version requirements (https://go.dev/doc/toolchain)
  • The gimme tool seems to be abandoned and does not work correctly for modern go versions (gimme stable does not work for latest Go (v1.21.0) travis-ci/gimme#210)
  • Designate the top level go.mod as the source of truth for the go version in the project
  • Includes notes on where this version needs to be updated to match
  • Update fedora image used in ci job to fedora 40 since it provides golang 1.22 in its repos

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 17, 2024
@fontivan fontivan force-pushed the sskeard/replace-gimme-tool branch from 45a1c62 to 6d8e2cf Compare October 17, 2024 20:14
@fontivan fontivan changed the title CNF-14990: Replace abandoned gimme tool & Provide alignment for golang version infra: CNF-14990: Replace abandoned gimme tool & Provide alignment for golang version Oct 17, 2024
@fontivan
Copy link
Contributor Author

The three failing CI tests ares failing since the CI does not use build root from the pr but instead from HEAD of the target branch. More details are available in https://issues.redhat.com/browse/CNF-15003

@fontivan
Copy link
Contributor Author

/cc @imiller0 @ffromani @lack

@openshift-ci openshift-ci bot requested review from ffromani, imiller0 and lack October 21, 2024 18:38
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 24, 2024
…r golang version

- Since golang 1.21, go is much better at managing its own version requirements (https://go.dev/doc/toolchain)
- The gimme tool seems to be abandoned and does not work correctly for modern go versions (travis-ci/gimme#210)
- Designate the top level go.mod as the source of truth for the go version in the project
- Includes notes on where this version needs to be updated to match
- Update fedora image used in ci job to fedora 40 since it provides golang 1.22 in its repos
@fontivan fontivan force-pushed the sskeard/replace-gimme-tool branch from 6d8e2cf to 020993e Compare October 24, 2024 17:05
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 24, 2024
- [email protected] required vbom.ml transitively which no longer exists
- [email protected] has updated its dependencies so that is no longer a problem
@fontivan fontivan force-pushed the sskeard/replace-gimme-tool branch from 7746cea to 44f4400 Compare October 24, 2024 20:02
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 25, 2024
@lack
Copy link
Member

lack commented Oct 25, 2024

/override e2e-aws-ci-tests e2e-aws-ran-profile images

Copy link
Contributor

openshift-ci bot commented Oct 25, 2024

@lack: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • e2e-aws-ci-tests
  • e2e-aws-ran-profile
  • images

Only the following failed contexts/checkruns were expected:

  • ci/prow/ci
  • ci/prow/e2e-aws-ci-tests
  • ci/prow/e2e-aws-ran-profile
  • ci/prow/images
  • ci/prow/security
  • ci/prow/ztp-ci
  • pull-ci-openshift-kni-cnf-features-deploy-master-ci
  • pull-ci-openshift-kni-cnf-features-deploy-master-e2e-aws-ci-tests
  • pull-ci-openshift-kni-cnf-features-deploy-master-e2e-aws-ran-profile
  • pull-ci-openshift-kni-cnf-features-deploy-master-images
  • pull-ci-openshift-kni-cnf-features-deploy-master-security
  • pull-ci-openshift-kni-cnf-features-deploy-master-ztp-ci
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override e2e-aws-ci-tests e2e-aws-ran-profile images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@lack
Copy link
Member

lack commented Oct 25, 2024

/override ci/prow/e2e-aws-ran-profile ci/prow/images ci/prow/e2e-aws-ci-tests

Copy link
Contributor

openshift-ci bot commented Oct 25, 2024

@lack: Overrode contexts on behalf of lack: ci/prow/e2e-aws-ci-tests, ci/prow/e2e-aws-ran-profile, ci/prow/images

In response to this:

/override ci/prow/e2e-aws-ran-profile ci/prow/images ci/prow/e2e-aws-ci-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ffromani
Copy link
Member

/approve

Copy link
Contributor

openshift-ci bot commented Oct 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ffromani, fontivan, lack

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 25, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit c574ca2 into openshift-kni:master Oct 25, 2024
7 checks passed
fontivan pushed a commit to fontivan/cnf-features-deploy that referenced this pull request Oct 25, 2024
…from fontivan/sskeard/replace-gimme-tool'

infra: CNF-14990: Replace abandoned gimme tool & Provide alignment for golang version
fontivan pushed a commit to fontivan/cnf-features-deploy that referenced this pull request Oct 25, 2024
…from fontivan/sskeard/replace-gimme-tool'

infra: CNF-14990: Replace abandoned gimme tool & Provide alignment for golang version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants