infra: CNF-14990: Replace abandoned gimme tool & Provide alignment for golang version #2073
Conversation
|
@fontivan: This pull request references CNF-14990 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
fontivan
force-pushed
the
sskeard/replace-gimme-tool
branch
from
45a1c62 to
6d8e2cf
Compare
fontivan
changed the title
|
The three failing CI tests ares failing since the CI does not use build root from the pr but instead from HEAD of the target branch. More details are available in https://issues.redhat.com/browse/CNF-15003 |
…r golang version - Since golang 1.21, go is much better at managing its own version requirements (https://go.dev/doc/toolchain) - The gimme tool seems to be abandoned and does not work correctly for modern go versions (travis-ci/gimme#210) - Designate the top level go.mod as the source of truth for the go version in the project - Includes notes on where this version needs to be updated to match - Update fedora image used in ci job to fedora 40 since it provides golang 1.22 in its repos
fontivan
force-pushed
the
sskeard/replace-gimme-tool
branch
from
6d8e2cf to
020993e
Compare
- [email protected] required vbom.ml transitively which no longer exists - [email protected] has updated its dependencies so that is no longer a problem
fontivan
force-pushed
the
sskeard/replace-gimme-tool
branch
from
7746cea to
44f4400
Compare
|
/override e2e-aws-ci-tests e2e-aws-ran-profile images |
|
@lack: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override ci/prow/e2e-aws-ran-profile ci/prow/images ci/prow/e2e-aws-ci-tests |
|
@lack: Overrode contexts on behalf of lack: ci/prow/e2e-aws-ci-tests, ci/prow/e2e-aws-ran-profile, ci/prow/images In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ffromani, fontivan, lack The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-merge-bot
bot
merged commit c574ca2
into
openshift-kni:master
…from fontivan/sskeard/replace-gimme-tool' infra: CNF-14990: Replace abandoned gimme tool & Provide alignment for golang version
…from fontivan/sskeard/replace-gimme-tool' infra: CNF-14990: Replace abandoned gimme tool & Provide alignment for golang version
gimme stabledoes not work for latest Go (v1.21.0) travis-ci/gimme#210)