-
Notifications
You must be signed in to change notification settings - Fork 233
Fix certificate paths for localdev scenario #8656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix certificate paths for localdev scenario #8656
Conversation
Looks like Konflux brough us to introduce a specific path for the ssl cert file. In CI base images, this path does not exist. Ensuring that there is a file where Konflux normally puts it, so the different runtime environments have the same situation on disk.
f58a359 to
784c988
Compare
locriandev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
/approve |
|
@joepvd: once the present PR merges, I will cherry-pick it on top of DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: joepvd The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f05b083
into
openshift-eng:openshift-4.22
|
@joepvd: new pull request created: #8657 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@joepvd: new pull request created: #8658 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@joepvd: new pull request created: #8659 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@joepvd: #8656 failed to apply on top of branch "openshift-4.18": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@joepvd: new pull request created: #8660 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Looks like Konflux brough us to introduce a specific path for the ssl cert file. In CI base images, this path does not exist. Ensuring that there is a file where Konflux normally puts it, so the different runtime environments have the same situation on disk.