Skip to content

Conversation

@joepvd
Copy link
Contributor

@joepvd joepvd commented Jan 19, 2026

Looks like Konflux brough us to introduce a specific path for the ssl cert file. In CI base images, this path does not exist. Ensuring that there is a file where Konflux normally puts it, so the different runtime environments have the same situation on disk.

Looks like Konflux brough us to introduce a specific path for the ssl
cert file. In CI base images, this path does not exist. Ensuring that
there is a file where Konflux normally puts it, so the different runtime
environments have the same situation on disk.
@joepvd joepvd force-pushed the fix-localdev-4.22 branch from f58a359 to 784c988 Compare January 19, 2026 09:24
Copy link
Contributor

@locriandev locriandev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 19, 2026
@joepvd
Copy link
Contributor Author

joepvd commented Jan 19, 2026

/approve
/cherrypick openshift-4.23
/cherrypick openshift-4.21
/cherrypick openshift-4.20
/cherrypick openshift-4.19
/cherrypick openshift-4.18

@openshift-cherrypick-robot

@joepvd: once the present PR merges, I will cherry-pick it on top of openshift-4.18, openshift-4.19, openshift-4.20, openshift-4.21, openshift-4.23 in new PRs and assign them to you.

Details

In response to this:

/approve
/cherrypick openshift-4.23
/cherrypick openshift-4.21
/cherrypick openshift-4.20
/cherrypick openshift-4.19
/cherrypick openshift-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 19, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joepvd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 19, 2026
@openshift-merge-bot openshift-merge-bot bot merged commit f05b083 into openshift-eng:openshift-4.22 Jan 19, 2026
1 check passed
@openshift-cherrypick-robot

@joepvd: new pull request created: #8657

Details

In response to this:

/approve
/cherrypick openshift-4.23
/cherrypick openshift-4.21
/cherrypick openshift-4.20
/cherrypick openshift-4.19
/cherrypick openshift-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@joepvd: new pull request created: #8658

Details

In response to this:

/approve
/cherrypick openshift-4.23
/cherrypick openshift-4.21
/cherrypick openshift-4.20
/cherrypick openshift-4.19
/cherrypick openshift-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@joepvd: new pull request created: #8659

Details

In response to this:

/approve
/cherrypick openshift-4.23
/cherrypick openshift-4.21
/cherrypick openshift-4.20
/cherrypick openshift-4.19
/cherrypick openshift-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@joepvd: #8656 failed to apply on top of branch "openshift-4.18":

Applying: Fix certificate paths for localdev scenario
Using index info to reconstruct a base tree...
M	ci_images/dnf_wrapper.sh
Falling back to patching base and 3-way merge...
Auto-merging ci_images/dnf_wrapper.sh
CONFLICT (content): Merge conflict in ci_images/dnf_wrapper.sh
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 Fix certificate paths for localdev scenario

Details

In response to this:

/approve
/cherrypick openshift-4.23
/cherrypick openshift-4.21
/cherrypick openshift-4.20
/cherrypick openshift-4.19
/cherrypick openshift-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@joepvd: new pull request created: #8660

Details

In response to this:

/approve
/cherrypick openshift-4.23
/cherrypick openshift-4.21
/cherrypick openshift-4.20
/cherrypick openshift-4.19
/cherrypick openshift-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants