-
Notifications
You must be signed in to change notification settings - Fork 19
ART-14031: Look at Konflux first when searching for RPMs in images #224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@adobes1: This pull request references ART-14031 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@adobes1: This pull request references ART-14031 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
artbotlib/brew_list.py
Outdated
| so.say(f"Sorry, I couldn't find image {nvr} RPMs: {e}") | ||
| return | ||
|
|
||
| so.snippet(payload='\n'.join(sorted(components)), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be improved with something like
if components:
so.snippet(payload='\n'.join(sorted(components)),
...
else: # no RPMs are used in the build
so.say(f'build {nvr} does not include any RPM')
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, addressed in 1215292
|
@adobes1: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
locriandev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: joepvd The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
bf00afd
into
openshift-eng:master
When asked a question related to RPMs in an image, release or a stream, art-bot will now first look through BigQuery for Konflux builds, and only if it doesn't find anything will it fall back looking at Brew build records.
Mainly affects the following queries:
Requires openshift-eng/art-tools#2074