Re-design benchmarks webpage #3447
Conversation
Signed-off-by: Rishabh Singh <[email protected]>
rishabh6788
requested review from
elfisher,
AMoo-Miki,
nknize,
krisfreedain,
peterzhuamazon,
CEHENKLE,
dtaivpp,
kolchfa-aws,
nateynateynate and
natebower
as code owners
|
@AMoo-Miki @ashwin-pc Please review the PR and let me know if anything can be further improved. |
|
Commenting for a review. |
| <h2>Why publish performance data?</h2> | ||
| <p> | ||
| The OpenSearch Project benchmarks the performance of OpenSearch releases to measure performance stability and gather data to inform software development. As an open-source project, we make this information publicly available in order to share it with the OpenSearch community. | ||
| </p> | ||
|
|
||
| <h2>Join the discussion</h2> | ||
| <p> | ||
| Questions or contributions? Connect with the OpenSearch community in the <a href="https://app.slack.com/client/T01QQ0Q5GMA/C0516H8EJ7R">#performance</a> channel on our public Slack. |
There was a problem hiding this comment.
This line should probably link to https://opensearch.org/slack.html. This link didn't work for me.
| @@ -64,66 +49,3 @@ benchmark_height_mobile: 6000 | |||
| <p> | |||
| To learn more about OpenSearch performance improvements through version 2.14, read <a href="https://opensearch.org/blog/opensearch-performance-2.14/">this blog post</a>. | |||
There was a problem hiding this comment.
This link should dynamically use the current version.
There was a problem hiding this comment.
This points to the last published performance blog. We are in the process of publishing a new blog, will updated once it is up.
| benchmark_domain: 'benchmarks.opensearch.org' | ||
| --- | ||
|
|
||
| <iframe src="https://{{ page.benchmark_domain }}/app/dashboards#/view/1a369150-e232-11ee-addb-f72c2feaa994?embed=true&_g=(filters:!(),refreshInterval:(pause:!t,value:0),time:(from:now-1w,to:now))&_a=(description:'',filters:!(('$state':(store:appState),meta:(alias:!n,disabled:!f,index:b4c18ee0-f35f-11ed-aff5-859eb6ed880f,key:query,negate:!f,type:custom,value:'%7B%22bool%22:%7B%22minimum_should_match%22:1,%22should%22:%5B%7B%22match_phrase%22:%7B%22user-tags.cluster-config%22:%22arm64-r6g.2xlarge-3-data-3-shards-1-replica-nmslib-cohere-1m%22%7D%7D,%7B%22match_phrase%22:%7B%22meta.tag_cluster-config%22:%22arm64-r6g.2xlarge-3-data-3-shards-1-replica-nmslib-cohere-1m%22%7D%7D%5D%7D%7D'),query:(bool:(minimum_should_match:1,should:!((match_phrase:(user-tags.cluster-config:arm64-r6g.2xlarge-3-data-3-shards-1-replica-nmslib-cohere-1m)),(match_phrase:(meta.tag_cluster-config:arm64-r6g.2xlarge-3-data-3-shards-1-replica-nmslib-cohere-1m))))))),fullScreenMode:!f,options:(hidePanelTitles:!f,useMargins:!t),query:(language:kuery,query:''),timeRestore:!f,title:'%5BVector%20Search%5D%20%5BNmslib%5D%201M%20Cohere%20768D',viewMode:view)&show-time-filter=true&hide-filter-bar=true"></iframe> |
There was a problem hiding this comment.
wrt to this iframe and all of the other iframes in this PR:
For the same reasons that page.benchmark_domain is a dynamic value, the URLs for each of these iframes needs to be dynamic. A different instance of OSD would more that likely have a different DashboardId; the 1a369150-e232-11ee-addb-f72c2feaa994 here would be different. Similarly, the IndexPatternId would be different as well; the b4c18ee0-f35f-11ed-aff5-859eb6ed880f in the URL.
Additionally, OSD provides a URL shortening feature which would work nice for these. My suggestion would be to have the full short-url for benchmark_url. Doing so, we wont need so many identical pages.
There was a problem hiding this comment.
I got the short-url point but not sure about Doing so, we wont need so many identical pages..
Do you mean to say we can achieve individual pages for each dashboard without having a dedicated .md files for them?
This is my first attempt on front-end programming, please excuse if my questions seem stupid. :)
There was a problem hiding this comment.
@AMoo-Miki If this is not a critical blocker can we have this merged and I can take up the refactoring in subsequent PRs?
Description
The current benchmarks webpage is single page that has details of what it shows and hyperlinks to different workload performance metrics dashboards that render the iframe when clicked upon.
The hyperlinks are horizontally stacked and clutter the space as more and more dashboards are getting added.
This PR moves all the horizontal hyperlinks to be vertically stacked in the left column of the page and also generates dedicated page for each workload's metric dashboards. The user can click on the desired workload's dashboard hyperlink which will then render the data from iframe.
benchmarks.mov
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the BSD-3-Clause License.