Fix OuiPopover does not change position on the scroll (#1184) #1185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkottr
requested review from
AMoo-Miki,
rednaksi91,
KrooshalUX,
BSFishy,
bandinib-amzn,
ashwin-pc,
joshuarrrr,
andreymyssak and
SergeyMyssak
as code owners
…ject#1184) Signed-off-by: Vladimir Komolov <[email protected]> Signed-off-by: Комолов Владимир <[email protected]>
|
I'm just gonna leave it here, I'm not gonna resolve any more conflicts. Now I'm sitting on the toilet and just pooping! |
|
Probably also fixes #107 |
Приветствую, господа из Сбера. Как видите, это хуйню так и не вмержили |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix OuiPopover does not change position on the scroll
(Set OuiPopover's scroll 3rd [add|remove]EventListener's argument to
true)Спаривание слонов – замечательный процесс (folk wisdom)
Issues Resolved
Fixes #1184
Check List
yarn lintyarn test-unitBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.