Adding code guidelines #502
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-gaievski
added
backport 2.x
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #502 +/- ##
============================================
- Coverage 84.65% 84.55% -0.11%
- Complexity 508 532 +24
============================================
Files 40 40
Lines 1505 1547 +42
Branches 234 244 +10
============================================
+ Hits 1274 1308 +34
Misses 128 128
- Partials 103 111 +8 ☔ View full report in Codecov by Sentry. |
navneet1v
reviewed
Jan 12, 2024
|
@martin-gaievski Can we update table of contents on dev guide as well? |
|
Hi @martin-gaievski ! Are you still taking care of this PR? Why this is still draft? |
Signed-off-by: Martin Gaievski <[email protected]>
martin-gaievski
force-pushed
the
added_code_guidelines
branch
from
ff18ce6
to
d693b58
Compare
|
@yuye-aws resumed work on this PR, feel free to leave comments |
martin-gaievski
force-pushed
the
added_code_guidelines
branch
2 times, most recently
from
b15c9d2
to
509cb24
Compare
Signed-off-by: Martin Gaievski <[email protected]>
martin-gaievski
force-pushed
the
added_code_guidelines
branch
from
509cb24
to
71d31e6
Compare
martin-gaievski
requested review from
heemin32,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
sean-zheng-amazon,
model-collapse,
zane-neo,
vibrantvarun,
zhichao-aws and
yuye-aws
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There are no code guidelines for the repo, this slows down new contributors and add cycles during code reviews.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.