Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TESTID-66: histogram tests #9290

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

silvaf-dev
Copy link
Contributor

@silvaf-dev silvaf-dev commented Jan 28, 2025

Description

This PR incorporates all four test suites from TESTID-66, save for the interactions with the inner elements of the histogram.

Issues Resolved

Screenshot

Screen.Recording.2025-01-28.at.5.1.mp4

Testing the changes

Changelog

  • skip

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@angle943
Copy link
Contributor

@ananzh @LDrago27 is it okay if the changelog is skipped for this?

@ananzh
Copy link
Member

ananzh commented Jan 29, 2025

@ananzh @LDrago27 is it okay if the changelog is skipped for this?

@silvaf-dev why skip changelog?

@ananzh
Copy link
Member

ananzh commented Jan 29, 2025

@silvaf-dev could you upload a video?

@github-actions github-actions bot added failed changeset and removed Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry labels Jan 29, 2025
Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.71%. Comparing base (95cfb51) to head (c90d707).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9290   +/-   ##
=======================================
  Coverage   61.71%   61.71%           
=======================================
  Files        3816     3816           
  Lines       91829    91829           
  Branches    14543    14543           
=======================================
  Hits        56668    56668           
  Misses      31506    31506           
  Partials     3655     3655           
Flag Coverage Δ
Linux_1 28.99% <ø> (ø)
Linux_2 56.46% <ø> (ø)
Linux_3 39.18% <ø> (ø)
Linux_4 28.90% <ø> (ø)
Windows_1 29.00% <ø> (ø)
Windows_2 56.41% <ø> (ø)
Windows_3 39.18% <ø> (-0.01%) ⬇️
Windows_4 28.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ananzh
Copy link
Member

ananzh commented Jan 29, 2025

I tried to update but it seems only for author

@github-actions github-actions bot added Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry and removed failed changeset labels Jan 29, 2025
cy.wait(1000);
cy.getElementByTestId('discoverIntervalSelect').should('have.value', 'auto');
cy.getElementByTestId('discoverIntervalDateRange').should('be.visible');
// TO DO: check histogram visualization
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you missed two aspects in https://github.com/opensearch-project/OpenSearch-Dashboards/pull/9290/files for

Select index pattern with time fieldSet time range to cover multiple monthsVerify the default auto interval displays autoTest with different time intervals (Weekly, Day) and verify histogram displaySwitch to PPL and verify visualization remains consistent across languages
  1. we need to switch to different intervals
  2. we need to switch language to verify the state persist like if you are using DQL - INDEX PATTERN and week, you need to switch to PPL and Lucence and check it is still week

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I switch to week/day only?
I'm already checking persistence for week on it(`check histogram visibility for ${config.testName}`)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is better to switch and verify all the intervals.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don;t think you verify the interval state is persistent in that test right? That is for visibility, like show or no show histogram.
When you change the interval, e.g. from auto to day and you switch language the interval should be day and should not go back to default auto.

@silvaf-dev
Copy link
Contributor Author

@silvaf-dev could you upload a video?

Done!

Copy link
Contributor

❌ Invalid Prefix For Manual Changeset Creation

Invalid description prefix. Found "add histogram tests". Only "skip" entry option is permitted for manual commit of changeset files.

If you were trying to skip the changelog entry, please use the "skip" entry option in the ##Changelog section of your PR description.

@github-actions github-actions bot added failed changeset and removed Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry labels Jan 29, 2025
@silvaf-dev
Copy link
Contributor Author

@ananzh @LDrago27 is it okay if the changelog is skipped for this?

I tried to add the changelog manually but GitHub Actions is complaining, as you can see above.

@github-actions github-actions bot added Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry and removed failed changeset labels Jan 29, 2025
Copy link
Contributor

❌ Changelog Entry Missing Hyphen

Changelog entries must begin with a hyphen (-).

@github-actions github-actions bot added failed changeset and removed Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry labels Jan 29, 2025
Copy link
Contributor

❌ Invalid Prefix For Manual Changeset Creation

Invalid description prefix. Found "test". Only "skip" entry option is permitted for manual commit of changeset files.

If you were trying to skip the changelog entry, please use the "skip" entry option in the ##Changelog section of your PR description.

cy.wait(1000);
cy.getElementByTestId('discoverIntervalSelect').should('have.value', 'auto');
cy.getElementByTestId('discoverIntervalDateRange').should('be.visible');
// TO DO: check histogram visualization
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don;t think you verify the interval state is persistent in that test right? That is for visibility, like show or no show histogram.
When you change the interval, e.g. from auto to day and you switch language the interval should be day and should not go back to default auto.

@ananzh ananzh added v2.19.0 discover_2.0-test Issues that are specific to the Discover 2.0 testing initiative backport 2.x backport 2.19 labels Jan 30, 2025
@github-actions github-actions bot added Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry and removed failed changeset labels Jan 30, 2025
Signed-off-by: Federico Silva <[email protected]>
Signed-off-by: Federico Silva <[email protected]>
Signed-off-by: Federico Silva <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport 2.19 discover_2.0-test Issues that are specific to the Discover 2.0 testing initiative repeat-contributor Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry v2.19.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants