[Cypress][TESTID-147] Add tests for table canvas in discover #9285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ananzh
requested review from
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli,
joshuali925 and
huyaboo
as code owners
ananzh
added
discover_2.0-test
opensearch-changeset-bot bot
added a commit
to ananzh/OpenSearch-Dashboards
that referenced
this pull request
Jan 28, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9285 +/- ##
==========================================
- Coverage 61.70% 61.70% -0.01%
==========================================
Files 3816 3816
Lines 91824 91824
Branches 14542 14542
==========================================
- Hits 56664 56662 -2
- Misses 31506 31507 +1
- Partials 3654 3655 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
7 tasks
ananzh
force-pushed
the
refactor-testid-147
branch
from
8ee2845 to
a4d2110
Compare
opensearch-changeset-bot bot
added a commit
to ananzh/OpenSearch-Dashboards
that referenced
this pull request
Jan 30, 2025
angle943
reviewed
Jan 30, 2025
| }).forEach((config) => { | ||
| describe(`${config.testName}`, () => { | ||
| beforeEach(() => { | ||
| if (config.datasetType === 'INDEX_PATTERN') { |
There was a problem hiding this comment.
nitpick: config.datasetType === DataTypes.IndexPattern.name (or something like that. i just hand wrote this)
|
Doesn't there need to be a change to |
angle943
reviewed
Jan 30, 2025
| }).forEach((config) => { | ||
| describe(`${config.testName}`, () => { | ||
| beforeEach(() => { | ||
| if (config.datasetType === 'INDEX_PATTERN') { |
ananzh
force-pushed
the
refactor-testid-147
branch
from
22b4ec0 to
4230fef
Compare
angle943
approved these changes
Jan 30, 2025
LDrago27
previously approved these changes
Jan 30, 2025
opensearch-changeset-bot bot
added a commit
to ananzh/OpenSearch-Dashboards
that referenced
this pull request
Jan 30, 2025
sejli
reviewed
Jan 30, 2025
| url: SECONDARY_ENGINE.url, | ||
| authType: 'no_auth', | ||
| }); | ||
| //cy.deleteWorkspaceByName(`${workspaceName}`); |
sejli
previously approved these changes
Jan 30, 2025
Issue resolved: opensearch-project#8947 Signed-off-by: Anan <[email protected]>
ananzh
force-pushed
the
refactor-testid-147
branch
from
dafe3eb to
4b61dc9
Compare
added it |
sejli
approved these changes
Jan 30, 2025
LDrago27
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add tests for table canvas in discover
Note: It depends on #9154 and needs to rebase after it is merged. Test won't work before that.
Issues Resolved
#8947
Screenshot
Changelog
Check List
yarn test:jestyarn test:jest_integration