[workspace]Hide the assistant entry when there isn't data2summary agent #9277
+29
−55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Qxisylolo <[email protected]>
Qxisylolo
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli,
joshuali925 and
huyaboo
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9277 +/- ##
=======================================
Coverage 61.69% 61.69%
=======================================
Files 3816 3815 -1
Lines 91693 91686 -7
Branches 14516 14515 -1
=======================================
- Hits 56569 56566 -3
+ Misses 31498 31496 -2
+ Partials 3626 3624 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
4 tasks
SuZhou-Joe
reviewed
Jan 27, 2025
| question$?: BehaviorSubject<string>; | ||
| } | ||
|
|
||
| const QueryAssistWrapper: React.FC<QueryAssistWrapperProps> = (props) => { | ||
| const [visible, setVisible] = useState(false); | ||
| const [question, setQuestion] = useState(''); | ||
| const [isQuerySummaryCollapsed, setIsQuerySummaryCollapsed] = useState(true); | ||
| const [isSummaryAgentAvailable, setIsSummaryAgentAvailable] = useState(false); |
There was a problem hiding this comment.
What about we using useObservable(props.isSummaryAgentAvailable$)?
SuZhou-Joe
reviewed
Jan 27, 2025
Comment on lines
-212
to
-230
| useEffect(() => { | ||
| setIsSummaryAgentAvailable(false); | ||
| const fetchSummaryAgent = async () => { | ||
| try { | ||
| const summaryAgentStatus = await checkAgentsExist( | ||
| props.http, | ||
| DATA2SUMMARY_AGENT_CONFIG_ID, | ||
| selectedDataset.current?.dataSource?.id | ||
| ); | ||
| setIsSummaryAgentAvailable(summaryAgentStatus.exists); | ||
| } catch (error) { | ||
| // eslint-disable-next-line no-console | ||
| console.error(error); | ||
| } | ||
| }; | ||
| if (isEnabledByCapability) { | ||
| fetchSummaryAgent(); | ||
| } | ||
| }, [selectedDataset.current?.dataSource?.id, props.http, isEnabledByCapability]); |
There was a problem hiding this comment.
Is there case that assistant is not installed but we turn on result summary?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr hides the assistant entry when there isn't data2summary agent
Screenshot
No agent:
Has agent:
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration