Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Query assistant]feat: add error callout when dataset is not supported #9232

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

SuZhou-Joe
Copy link
Member

Description

Add a error callout and disable input and button to tell users that current selected dataset is not supported for query generation.

Issues Resolved

Screenshot

Normal index pattern

image

Not supported dataset

image

Testing the changes

Changelog

  • feat: add error callout when dataset is not supported

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 61.67%. Comparing base (b0bfa6c) to head (f0e7f48).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
...ublic/query_assist/components/query_assist_bar.tsx 83.33% 0 Missing and 1 partial ⚠️
...nts/public/query_assist/utils/create_extension.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9232   +/-   ##
=======================================
  Coverage   61.66%   61.67%           
=======================================
  Files        3817     3817           
  Lines       91711    91719    +8     
  Branches    14515    14520    +5     
=======================================
+ Hits        56558    56564    +6     
- Misses      31524    31525    +1     
- Partials     3629     3630    +1     
Flag Coverage Δ
Linux_1 29.04% <ø> (ø)
Linux_2 56.45% <ø> (ø)
Linux_3 39.09% <ø> (-0.01%) ⬇️
Linux_4 28.98% <75.00%> (+<0.01%) ⬆️
Windows_1 29.05% <ø> (ø)
Windows_2 56.40% <ø> (ø)
Windows_3 39.09% <ø> (+<0.01%) ⬆️
Windows_4 28.98% <75.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant