Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover] Adding Cypress Tests for S3 Datasets #9113

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

sejli
Copy link
Member

@sejli sejli commented Dec 21, 2024

Description

Adding integration tests for S3 datasets in query enhancements

Issues Resolved

Screenshot

Testing the changes

Changelog

  • test: Adding Cypress Tests for S3 Datasets

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link

codecov bot commented Dec 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.90%. Comparing base (66331eb) to head (4dddc97).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9113   +/-   ##
=======================================
  Coverage   60.90%   60.90%           
=======================================
  Files        3808     3808           
  Lines       91178    91178           
  Branches    14396    14396           
=======================================
  Hits        55529    55529           
  Misses      32095    32095           
  Partials     3554     3554           
Flag Coverage Δ
Linux_1 28.99% <ø> (ø)
Linux_2 56.38% <ø> (ø)
Linux_3 ?
Linux_4 29.01% <ø> (ø)
Windows_1 29.00% <ø> (ø)
Windows_2 56.34% <ø> (ø)
Windows_3 38.01% <ø> (ø)
Windows_4 29.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant