Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory leaks of Vega charts on refresh #9067

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

facewise
Copy link

@facewise facewise commented Dec 17, 2024

Description

See elastic/kibana#146170 and elastic/kibana#147309 for details.

This fix is originally created by @alexwizp.

Changelog

  • fix: Memory leaks of Vega charts on refresh

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link
Contributor

❌ Invalid Prefix For Manual Changeset Creation

Invalid description prefix. Found "fix". Only "skip" entry option is permitted for manual commit of changeset files.

If you were trying to skip the changelog entry, please use the "skip" entry option in the ##Changelog section of your PR description.

Copy link
Contributor

❌ Invalid Prefix For Manual Changeset Creation

Invalid description prefix. Found "fix". Only "skip" entry option is permitted for manual commit of changeset files.

If you were trying to skip the changelog entry, please use the "skip" entry option in the ##Changelog section of your PR description.

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 60.86%. Comparing base (f06a478) to head (1da3b73).

Files with missing lines Patch % Lines
...s/vis_type_vega/public/vega_view/vega_base_view.js 50.00% 2 Missing ⚠️
...is_type_vega/public/vega_inspector/vega_adapter.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9067      +/-   ##
==========================================
- Coverage   60.86%   60.86%   -0.01%     
==========================================
  Files        3808     3808              
  Lines       91209    91213       +4     
  Branches    14410    14410              
==========================================
  Hits        55514    55514              
- Misses      32154    32158       +4     
  Partials     3541     3541              
Flag Coverage Δ
Linux_1 ?
Linux_2 56.38% <ø> (ø)
Linux_3 37.93% <ø> (?)
Linux_4 29.01% <ø> (ø)
Windows_1 29.03% <40.00%> (-0.01%) ⬇️
Windows_2 56.34% <ø> (ø)
Windows_3 37.93% <ø> (ø)
Windows_4 29.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant