[Purify] remove upsells and branding from pre-fork #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
May 30, 2021
|
✅ DCO Check Passed cfa4523 |
tmarkley
reviewed
Jun 1, 2021
|
|
||
| export function createTileMapTypeDefinition(dependencies) { | ||
| const CoordinateMapsVisualization = createTileMapVisualization(dependencies); | ||
| const { uiSettings, getServiceSettings } = dependencies; | ||
|
|
||
| return { | ||
| name: 'tile_map', | ||
| getInfoMessage: getDeprecationMessage, |
There was a problem hiding this comment.
Is this prop referenced elsewhere?
There was a problem hiding this comment.
This is optional on the type visType. So removing it here satisfies the problem we are seeing.
Left-over upsells and branding that were missed in previous updates since they are not easy to catch. Issues: opensearch-project#359 opensearch-project#388 opensearch-project#384 Signed-off-by: Kawika Avilla <[email protected]>
kavilla
force-pushed
the
avillk/remove-upsells
branch
from
cfa4523 to
35e9a38
Compare
|
✅ DCO Check Passed 35e9a38 |
tmarkley
approved these changes
Jun 2, 2021
kavilla
added a commit
that referenced
this pull request
Jun 3, 2021
Left-over upsells and branding that were missed in previous updates since they are not easy to catch. Issues: #359 #388 #384 Signed-off-by: Kawika Avilla <[email protected]>
kavilla
added a commit
that referenced
this pull request
Jun 3, 2021
Left-over upsells and branding that were missed in previous updates since they are not easy to catch. Issues: #359 #388 #384 Signed-off-by: Kawika Avilla <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Left-over upsells and branding that were missed in previous
updates since they are not easy to catch.
Signed-off-by: Kawika Avilla [email protected]
Issues Resolved
#359
#388
#384
Check List