Skip to content

Conversation

@mzecc
Copy link
Collaborator

@mzecc mzecc commented Dec 3, 2025

Description

Checklist

Please confirm that this pull request has done the following:

  • Tests added
  • Documentation added (where applicable)
  • Changelog item added to changelog/

Copy link
Collaborator

@znichollscr znichollscr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice. funny that the path moved

Can you add a trivial changelog that just says "Fixed failing MacOS CI" or similar, then good to merge

# # Useful if the path appears to have changed
# find / -name 'libgfortran.5.dylib' 2>/dev/null
echo "DYLD_LIBRARY_PATH=/opt/homebrew/lib/gcc/12/" >> $GITHUB_ENV
# echo "DYLD_LIBRARY_PATH=/opt/homebrew/lib/gcc/12/" >> $GITHUB_ENV
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# echo "DYLD_LIBRARY_PATH=/opt/homebrew/lib/gcc/12/" >> $GITHUB_ENV

If you want to clean up a bit

@mzecc
Copy link
Collaborator Author

mzecc commented Dec 5, 2025

Ok, I made some clean-up and added the 41.trivial.md. I squashed some commits as well and apparently it worked. All good to merge I think.

@znichollscr
Copy link
Collaborator

Merging main into this branch cleaned up the diff, looks all good now

@znichollscr znichollscr merged commit 6a6f4c3 into openscm:main Dec 5, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants