Schema: rationalize dates, fixes #162 #486
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Simplifies dates as detailed in #162
startDate
andendDate
, PEP StatusstartDate
andendDate
, EntityfoundingDate
anddissolutionDate
, and formedByStatutedate
are more strict - only date (YYYY-MM-DD) is valid; timestamps and partial dates are no longer valid.birthDate
anddeathDate
are more strict - year (YYYY), year and month (YYYY-MM) and year, month and day (YYYY-MM-DD) are valid, but timestamps are no longer valid.creationDate
, PublicationDetailspublicationDate
are less strict - valid as date or date-time (partial dates are still not valid).Updates tests/date and adds a couple of extra tests.
Check the new schema descriptions and definitions against the spreadsheet
@kd-ods
(Closes/Relates to) issue: #162
Translations
translating. See: https://openownership.github.io/bods-dev-handbook/translations.html
Documentation & Release
https://openownership.github.io/bods-dev-handbook/standard_releases.html