Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema: rationalize dates, fixes #162 #486

Merged
merged 2 commits into from
Oct 12, 2023
Merged

Schema: rationalize dates, fixes #162 #486

merged 2 commits into from
Oct 12, 2023

Conversation

rhiaro
Copy link
Collaborator

@rhiaro rhiaro commented Aug 9, 2023

Overview

  • What does this pull request do?

Simplifies dates as detailed in #162

  • Interest startDate and endDate, PEP Status startDate and endDate, Entity foundingDate and dissolutionDate, and formedByStatute date are more strict - only date (YYYY-MM-DD) is valid; timestamps and partial dates are no longer valid.
  • Person birthDate and deathDate are more strict - year (YYYY), year and month (YYYY-MM) and year, month and day (YYYY-MM-DD) are valid, but timestamps are no longer valid.
  • Annotation creationDate, PublicationDetails publicationDate are less strict - valid as date or date-time (partial dates are still not valid).

Updates tests/date and adds a couple of extra tests.

  • How can a reviewer test or examine your changes?

Check the new schema descriptions and definitions against the spreadsheet

  • Who is best placed to review it?

@kd-ods

(Closes/Relates to) issue: #162

Translations

Documentation & Release

@rhiaro rhiaro requested a review from kd-ods August 9, 2023 11:41
@rhiaro rhiaro changed the base branch from 0.4.0-json-schema-202012 to main August 9, 2023 11:42
@rhiaro rhiaro changed the base branch from main to 0.4.0-json-schema-202012 August 9, 2023 11:44
@rhiaro rhiaro force-pushed the 0.4.0-json-schema-202012 branch from f70cd2c to 38c3bd8 Compare August 14, 2023 12:27
@rhiaro rhiaro force-pushed the 0.4.0-162-date-formats branch from 8b59fcc to 3439f0b Compare August 14, 2023 14:43
Copy link
Collaborator

@kd-ods kd-ods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rhiaro - Is \d definitely valid regex here? I can't get your pattern to match dates using https://regex101.com/ . Poss an issue with me or the validator!

Otherwise this PR looks ready to go to me.

schema/person-statement.json Show resolved Hide resolved
@rhiaro rhiaro force-pushed the 0.4.0-json-schema-202012 branch from 38c3bd8 to ca9818c Compare October 10, 2023 10:03
Base automatically changed from 0.4.0-json-schema-202012 to main October 10, 2023 17:23
@rhiaro rhiaro force-pushed the 0.4.0-162-date-formats branch from 3439f0b to 1aabd48 Compare October 10, 2023 17:30
@rhiaro rhiaro requested a review from kd-ods October 12, 2023 14:34
@rhiaro rhiaro merged commit de1b20a into main Oct 12, 2023
2 checks passed
@rhiaro rhiaro deleted the 0.4.0-162-date-formats branch October 12, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants