-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement example apps benchmarking #117
Conversation
|
commit: |
be387fa
to
557ddba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this.
I added a few comments.
Co-authored-by: Victor Berchet <[email protected]>
c35adea
to
f54f54f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks for the updates
As discussed with the team we want to look into application performance improvements, but before doing that it's important to know where we start, so we can also validate our solutions and see if we are actually improving things.
So for this I'm introducing here some rudimental benchmarking capabilities that rely on our
examples
.The
benchmark
script I'm adding here allows any user (including external contributors) to log in using wrangler, deploy and benchmark the example applications.The benchmarking here simply consists in
fetch
ing from the deployed application and seeing how long the fetch took (usingperformance.now()
calls).This is the result of running the script (
pnpm benchmark
at the root of the monorepo):`2024-11-01_16-41-33.json.json`
Things can be improved later on and we can also generalize the script here (I tried making it fairly generic/reusable), but as a starting point I think this should (hopefully) be pretty adequate 🙂