Add middleware support #113

vicb · 2024-10-30T21:09:05Z

~~It's missing e2e tests in the added middleware example but~~ everything seems to be working fine 🎉

Many thanks to @conico974 for merging the required changes in @opennextjs/aws !

Known issues as of Oct 31, 2024:

It is not possible to set headers in middleware/next config yet but that should come next week.

changeset-bot · 2024-10-30T21:09:09Z

⚠️ No Changeset found

Latest commit: 8c022f7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

pkg-pr-new · 2024-10-30T21:09:38Z

Open in Stackblitz

pnpm add https://pkg.pr.new/@opennextjs/cloudflare@113

commit: cee60bc

conico974

Just a few question/comment.
Great job anyway

examples/api/open-next.config.ts

packages/cloudflare/src/cli/templates/worker.ts

packages/cloudflare/package.json

examples/middleware/package.json

examples/middleware/e2e/playwright.config.ts

james-elicx · 2024-10-31T21:45:58Z

examples/middleware/e2e/playwright.config.ts

+  /* Run your local dev server before starting the tests */
+  webServer: {
+    command: "pnpm preview:worker",
+    url: "http://localhost:8770",


Suggested change

url: "http://localhost:8770",

url: "http://localhost:8774",

packages/cloudflare/src/cli/build/index.ts

packages/cloudflare/README.md

examples/middleware/e2e/base.spec.ts

Update examples/middleware/package.json Co-authored-by: James Anderson <[email protected]>

middleware step

dario-piotrowicz · 2024-10-31T13:59:34Z

.gitignore

@@ -3,5 +3,6 @@ node_modules

 output
 .worker-next


shall we remove .worker-next if it's not used anymore?

examples/create-next-app/tsconfig.json

examples/middleware/package.json

packages/cloudflare/src/cli/build/build-next-app.ts

packages/cloudflare/src/cli/build/build-worker.ts

examples/create-next-app/open-next.config.ts

packages/cloudflare/src/cli/templates/worker.ts

dario-piotrowicz · 2024-11-04T10:57:46Z

examples/middleware/README.md

+## Deploy your own
+
+Deploy the example using [Vercel](https://vercel.com?utm_source=github&utm_medium=readme&utm_campaign=next-example):
+
+[![Deploy with Vercel](https://vercel.com/button)](https://vercel.com/new/clone?repository-url=https://github.com/vercel/next.js/tree/canary/examples/middleware&project-name=middleware&repository-name=middleware)
+
+## How to use
+
+Execute [`create-next-app`](https://github.com/vercel/next.js/tree/canary/packages/create-next-app) with [npm](https://docs.npmjs.com/cli/init), [Yarn](https://yarnpkg.com/lang/en/docs/cli/create/), or [pnpm](https://pnpm.io) to bootstrap the example:
+
+```bash
+npx create-next-app --example middleware middleware-app
+```
+
+```bash
+yarn create next-app --example middleware middleware-app
+```
+
+```bash
+pnpm create next-app --example middleware middleware-app
+```
+
+Deploy it to the cloud with [Vercel](https://vercel.com/new?utm_source=github&utm_medium=readme&utm_campaign=next-example) ([Documentation](https://nextjs.org/docs/deployment)).


Suggested change

## Deploy your own

Deploy the example using [Vercel](https://vercel.com?utm_source=github&utm_medium=readme&utm_campaign=next-example):

[![Deploy with Vercel](https://vercel.com/button)](https://vercel.com/new/clone?repository-url=https://github.com/vercel/next.js/tree/canary/examples/middleware&project-name=middleware&repository-name=middleware)

## How to use

Execute [`create-next-app`](https://github.com/vercel/next.js/tree/canary/packages/create-next-app) with [npm](https://docs.npmjs.com/cli/init), [Yarn](https://yarnpkg.com/lang/en/docs/cli/create/), or [pnpm](https://pnpm.io) to bootstrap the example:

```bash

npx create-next-app --example middleware middleware-app

```

```bash

yarn create next-app --example middleware middleware-app

```

```bash

pnpm create next-app --example middleware middleware-app

```

Deploy it to the cloud with [Vercel](https://vercel.com/new?utm_source=github&utm_medium=readme&utm_campaign=next-example) ([Documentation](https://nextjs.org/docs/deployment)).

What are the changes here?

Just removing the vercel specific documentation

dario-piotrowicz

Looks good to me 🙂

It's very cool and promising seeing the integration with ona 🤩 🚀

vicb · 2024-11-04T13:03:54Z

Thanks for the reviews and the approval @dario-piotrowicz.

As you noted there are still a few rough edges but they will be solved as the integration progresses - and I think those are ok in the experimental branch.

My plan is to merge this PR and then push the changes to the experimental branch so that it's easier for users to install and test the package.

vicb added 2 commits October 30, 2024 19:17

feat: import the middleware example

2d18dc3

feat: adapt the middleware example for cloudflare

0435b82

vicb requested review from petebacondarwin, james-elicx and dario-piotrowicz October 30, 2024 21:09

vicb force-pushed the open-next branch 2 times, most recently from feb269e to 1debd9b Compare October 30, 2024 21:50

conico974 reviewed Oct 30, 2024

View reviewed changes

examples/api/open-next.config.ts Outdated Show resolved Hide resolved

examples/api/open-next.config.ts Show resolved Hide resolved

packages/cloudflare/src/cli/templates/worker.ts Show resolved Hide resolved

packages/cloudflare/package.json Show resolved Hide resolved

vicb force-pushed the open-next branch from 1debd9b to cee60bc Compare October 31, 2024 07:40

vicb mentioned this pull request Oct 31, 2024

feat: Easier way to create an OpenNext config for cloudflare #114

Open

james-elicx reviewed Oct 31, 2024

View reviewed changes

vicb and others added 3 commits November 1, 2024 09:39

test: add middleware e2e

8c022f7

Update examples/middleware/package.json Co-authored-by: James Anderson <[email protected]>

add branch prereleases (#115)

29aa483

feat: add middleware support

280bad0

middleware step

dario-piotrowicz reviewed Nov 1, 2024

View reviewed changes

dario-piotrowicz reviewed Nov 4, 2024

View reviewed changes

examples/create-next-app/open-next.config.ts Show resolved Hide resolved

dario-piotrowicz reviewed Nov 4, 2024

View reviewed changes

packages/cloudflare/src/cli/templates/worker.ts Show resolved Hide resolved

dario-piotrowicz reviewed Nov 4, 2024

View reviewed changes

vicb force-pushed the open-next branch from a3a33a0 to 8c022f7 Compare November 4, 2024 12:15

dario-piotrowicz approved these changes Nov 4, 2024

View reviewed changes

vicb merged commit dd5b64e into merge-open-next Nov 4, 2024

vicb deleted the open-next branch November 4, 2024 13:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add middleware support #113

Add middleware support #113

vicb commented Oct 30, 2024 •

edited

Loading

changeset-bot bot commented Oct 30, 2024 •

edited

Loading

pkg-pr-new bot commented Oct 30, 2024 •

edited

Loading

conico974 left a comment

james-elicx Oct 31, 2024

dario-piotrowicz Oct 31, 2024

dario-piotrowicz Nov 4, 2024

vicb Nov 4, 2024

dario-piotrowicz Nov 4, 2024

dario-piotrowicz left a comment

vicb commented Nov 4, 2024

Add middleware support #113

Add middleware support #113

Conversation

vicb commented Oct 30, 2024 • edited Loading

changeset-bot bot commented Oct 30, 2024 • edited Loading

⚠️ No Changeset found

pkg-pr-new bot commented Oct 30, 2024 • edited Loading

conico974 left a comment

Choose a reason for hiding this comment

james-elicx Oct 31, 2024

Choose a reason for hiding this comment

dario-piotrowicz Oct 31, 2024

Choose a reason for hiding this comment

dario-piotrowicz Nov 4, 2024

Choose a reason for hiding this comment

vicb Nov 4, 2024

Choose a reason for hiding this comment

dario-piotrowicz Nov 4, 2024

Choose a reason for hiding this comment

dario-piotrowicz left a comment

Choose a reason for hiding this comment

vicb commented Nov 4, 2024

vicb commented Oct 30, 2024 •

edited

Loading

changeset-bot bot commented Oct 30, 2024 •

edited

Loading

pkg-pr-new bot commented Oct 30, 2024 •

edited

Loading