Skip to content

Conversation

@Chinmay7070
Copy link

@Chinmay7070 Chinmay7070 commented Dec 20, 2025

Description of what I changed

  1. Added a new JUnit 5 test class AllergyTest.
  2. Implemented unit tests for the Allergy.hasSameValues method.
  3. Covered positive and negative cases for allergy ID, patient, allergen (coded and non-coded), severity, comments, and reactions.
  4. Used existing OpenMRS test datasets and BaseContextSensitiveTest.
  5. No production code changes were made.

see https://openmrs.atlassian.net/browse/TRUNK-5472

Checklist: I completed these to help reviewers :)

  • My IDE is configured to follow the code style of this project.

    No? Unsure? -> configure your IDE, format the code and add the changes with git add . && git commit --amend

  • I have added tests to cover my changes. (If you refactored
    existing code that was well tested you do not have to add tests)

    No? -> write tests and add them to this commit git add . && git commit --amend

  • I ran mvn clean package right before creating this pull request and
    added all formatting changes to my commit.

    No? -> execute above command

  • All new and existing tests passed.

    No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.

  • My pull request is based on the latest changes of the master branch.

    No? Unsure? -> execute command git pull --rebase upstream master

@Chinmay7070
Copy link
Author

Hi @dkayiwa, @ibacher,

I wanted to share that I’ve already worked on this issue and opened a PR that adds unit tests for Allergy#hasSameValues. The intent is to improve test coverage only, so that future refactoring to address the Sonar-reported cyclomatic complexity can be done more safely.

When you have a chance, I’d really appreciate your feedback on whether this approach looks appropriate, or if there are any additional scenarios or changes you’d recommend. I’m happy to make adjustments based on your guidance.

Thank you for your time and support.

@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant