Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Lyft route to specify region. #198

Closed

Conversation

rowillia
Copy link

As part of some refactoring we're moving some routes around to include the region they're serving (similar to GBFS - https://github.com/NABSA/gbfs/blob/master/systems.csv). The old route will continue to work for SMO/LAX, but ideally we'd migrate over in the near future.

As part of some refactoring we're moving some routes around.  The old route will
continue to work for SMO/LAX, but ideally we'd migrate over in the near future.
@hunterowens
Copy link
Collaborator

@rowillia

Since the systems.csv represents a global list of MDS systems/provider_ids, I would recommend that we keep the listing in providers.csv the same as currently, even if to make full requests you will need the path info.

Some implementations may require a postfix/prefix (ie, LAX, los-angeles) to form correct URLs. Currently, that is support inside the .config of the MDS provider library.

@rowillia
Copy link
Author

@hunterowens where can I find that file? I don't see a .config in https://github.com/cityofsantamonica/mds-provider or in this repo.

@thekaveman
Copy link
Collaborator

thekaveman commented Dec 13, 2018

It's a little confusing (any suggestions for how to improve this are welcome) But basically you can configure a Provider instance with an object of config data here https://github.com/CityofSantaMonica/mds-provider/blob/dev/mds/providers.py#L37

And the ApiClient looks for this when constructing the URL here: https://github.com/CityofSantaMonica/mds-provider/blob/dev/mds/api/client.py#L40

Definitely non-standard behavior. Maybe we should consider if this can be built into the spec.

EDIT: if anyone wants to help with the docs 😄

@rowillia
Copy link
Author

@thekaveman Yeah, I'm happy to propose something. If MDS picks up in popularity we're going to want to segment endpoints by region (similar to how most GBFS feeds operate) to control who has access to what data.

@hunterowens
Copy link
Collaborator

@rowillia Yeah, happy to add this into the core MDS if wanted to providers.

@hunterowens
Copy link
Collaborator

Additionally, you can control which users have access to which pieces of information via the token mechanism, JWT additionally allows you to encode more information in the token.

@hunterowens
Copy link
Collaborator

closing this for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants