Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(api): make windowSize optional #631

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(api): make windowSize optional #631

wants to merge 1 commit into from

Conversation

tothandras
Copy link
Contributor

Set to MINUTE by default in Cloud.

@tothandras tothandras added area/api release-note/bug-fix Release note: Bug Fixes labels Feb 21, 2024
hekike
hekike reviewed Feb 21, 2024
View reviewed changes
Copy link
Contributor

@hekike hekike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will change read type as well including SDKs

hekike
hekike requested changes Feb 21, 2024
View reviewed changes
Copy link
Contributor

@hekike hekike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's figure out how we can make it optional only in payload.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hekike hekike hekike requested changes

@sagikazarmark sagikazarmark Awaiting requested review from sagikazarmark

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
area/api release-note/bug-fix Release note: Bug Fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tothandras @hekike