Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Features under separate package #1547

Merged
merged 2 commits into from
Sep 23, 2024
Merged

Conversation

GAlexIHU
Copy link
Contributor

Overview

The idea with this change is to minimize how much we'll step on each others feet in the following period. The thinking is as follows:

  • It was already questionable before whether openmeter/productcatalog was the right place for features
  • We most likely will be contributing a significant amount inside openmeter/productcatalog which could&will cause conflicts
  • In case productcatalog would ever have subpackages there easily can be circular dependency issues if they depend on feature. (Its not clear if we want that or not)
  • It is now very easy to move features once we figure out where it truly belongs (just a bunch of mass replace + aliasing; and then we can remove the aliasing too)
  • Currently its used in 4 places in the cloud distribution which is not such a big hassle to fix up

Drawbacks:

  • Some variables had to be renamed from feature to feat

@GAlexIHU GAlexIHU merged commit 56ac8e4 into main Sep 23, 2024
19 checks passed
@GAlexIHU GAlexIHU deleted the refactor/feature-package branch September 23, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/misc Miscellaneous changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants