Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cursor pagination to internal streaming API #1534

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

GAlexIHU
Copy link
Contributor

@GAlexIHU GAlexIHU commented Sep 18, 2024

Relates to Issue #1527

Overview

Adds cursor based pagination to the internal streaming API. Unfortunately this requires a change in the main events table, we'd have to change the ordering in the table definition for reasonable query performance (id is used as the tie-breaker which previously wasn't present in the index)

Notes for reviewer

  • Its currently unclear how to expose this through the external API, should we do a V2 API for this, etc... I'd treat that as a separate effort, this is just the ground-work for that.
  • To emphasize again, changing the table ordering is a significant issue, we need to measure the impact

@GAlexIHU GAlexIHU added the kind/feature New feature or request label Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant