Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support feature creation by meter Id OM-719 #1144

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Support feature creation by meter Id OM-719 #1144

wants to merge 3 commits into from

Conversation

GAlexIHU
Copy link
Contributor

@GAlexIHU GAlexIHU commented Jul 4, 2024 •
edited
Loading

Overview

Includes (per commit):

  • make task to run e2e tests
  • removes *map[string]string for feature meterGroupByFilters and replaces it with a custom type
  • Proposed solution for OM-719 : Create Feature with MeterID

Notes for reviewer

If the proposed solution's not accepted I'll revert as I'd still like to get the first 2 commits merged

  • This PR changes the API which I don't like that much, another option would be to add an extra input property meterId and then we'd document which has precedence, but I that doesn't seem the best either.
  • MeterID shouldn't be added to the Feature directly (IMO) as in most cases MeterID doesn't exist... the idea is to provide a convenience when creating a feature

@GAlexIHU GAlexIHU added release-note/feature Release note: Exciting New Features kind/refactor Code refactor, cleanup or minor improvement labels Jul 4, 2024
@GAlexIHU GAlexIHU changed the title Support feature creation by meter Id Support feature creation by meter Id OM-719 Jul 4, 2024
turip
turip requested changes Jul 4, 2024
View reviewed changes
internal/productcatalog/httpdriver/feature.go
if err := commonhttp.JSONRequestBodyDecoder(r, &featureIn); err != nil {
return featureIn, err
parsedBody := api.CreateFeatureJSONRequestBody{}
emptyFeature := productcatalog.CreateFeatureInputs{}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should switch to pointers (regardless, I am fine merging this)

pkg/convert/ptr.go Show resolved Hide resolved
@GAlexIHU GAlexIHU mentioned this pull request Jul 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turip turip turip approved these changes

Assignees
No one assigned
Labels
kind/refactor Code refactor, cleanup or minor improvement release-note/feature Release note: Exciting New Features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GAlexIHU @turip