Refactor CylinderSector to allow angles more than 180° #3296
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A proposition for change solving issue #3293, that causes the CylinderSector to have an angle limit of 180° rather than 360°.
Fixes
The existing
CylinderSector
class is renamed to_HalfCylinderSector
, the_
prefix indicating that it is for internal use only.A new
CynlinderSector
class is created, and is a composite surface made up of two_HalfCylinderSector
like so:This naturally doubles the angle limit to from 180° to 360°.
Pros: This fixes requires very little additionnal code and no additionnal trig/boolean algebra, with no API change
Cons: This add an unecessary middle plane if the angle is less than 180°
Checklist