-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add VTU export for Unstructured meshes #3290
base: develop
Are you sure you want to change the base?
Add VTU export for Unstructured meshes #3290
Conversation
@shimwell With this PR one should be able to mesh CadQuery shapes, and export legacy VTK, or VTU, without running into module conflicts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rherrero-pf for the contribution! The additional format support will be nice to have. And thank you for updating the VTK imports.
Mostly comments on the new test here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rherrero-pf for this PR!
@pshriwise I went ahead and made the necessary updates based on your review. If you're satisfied, please approve so we can merge this in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks @rherrero-pf, @paulromano!
I see auto merge was enabled but one of the CI runners failed. Rerunning that runner just in case it was a temporary bug |
This failing test is strange, if it helps I am also changing the same vtk function on this other PR |
Description
Added method to export an unstructured mesh in .vtu format, and removed the dependency on the VTK module, which clashes with CadQuery.
Fixes # (issue)
Fixes issue #3289
Checklist