#4146: Add deprecation notice on create_galley_from_file

src/core/migrations/0088_fix_untyped_galleys.py

@@ -11,12 +11,13 @@ class Migration(migrations.Migration):
         ('metrics', '0010_auto_20230317_1534'),
     ]
 
+
 def fix_untyped_galleys(apps, schema_editor):
     """ Fixes galleys that haven't had a type set and linked metrics records"""
 
     Galley = apps.get_model('core', 'Galley')
     ArticleAccess = apps.get_model('metrics','ArticleAccess')
-    for galley in Galley.objects.filter(type="",file__isnull=False, article__isnull=False):
+    for galley in Galley.objects.filter(type="", file__isnull=False, article__isnull=False):
         _, galley_type = get_galley_label_and_type(galley.file)
         galley.galley_type = galley_type
         galley.save()
@@ -27,6 +28,6 @@ def fix_untyped_galleys(apps, schema_editor):
         ).update(galley_type=galley_type)
 
 
-    operations = [
-        migrations.RunPython(fix_untyped_galleys, reverse_code=migrations.RunPython.noop),
-    ]
+operations = [
+    migrations.RunPython(fix_untyped_galleys, reverse_code=migrations.RunPython.noop),
+]

src/journal/logic.py

@@ -13,6 +13,7 @@
 from shutil import copyfile
 from urllib.parse import urlencode
 from uuid import uuid4
+import warnings
 
 from django.contrib import messages
 from django.conf import settings
@@ -85,6 +86,11 @@ def list_scss(journal):
 def create_galley_from_file(file_object, article_object, owner=None):
     # we copy the file here so that the user submitting has no control over the typeset files
     # N.B. os.path.splitext[1] always returns the final file extension, even in a multi-dotted (.txt.html etc.) input
+
+    warnings.warn(
+        "'create_galley_from_file' is deprecated and will be removed,"
+        " use production.logic.save_galley instead."
+        )
     new_filename = str(uuid4()) + str(os.path.splitext(file_object.uuid_filename)[1])
     folder_structure = os.path.join(settings.BASE_DIR, 'files', 'articles', str(article_object.id))