Use Bootstrap tabs #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tabbed UI: |
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After looking into #14 and @isaacchansky's nice PR I realized that Bootstrap tabs are a straightfoward way to unify the mobile and desktop views with minimal code upheaval.
The tradeoff will be getting the map to display in a Bootstrap tab for mobile views. From the usability testing so far, users are primarily concerned with the questionnaire/facets rather than the map so this seems good enough for more testing.
I propose we use this for now so we can get feedback and determine the priority of the mobile map (#30).