-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple YubiKeys support #583
Open
renatav
wants to merge
35
commits into
master
Choose a base branch
from
renatav/multiple-yubikeys
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s over all inserted yubikeys
…ed to yubikey store
…fegined in metadata
renatav
force-pushed
the
renatav/multiple-yubikeys
branch
from
January 24, 2025 05:37
1737f6d
to
87eb87a
Compare
…r various roles, initial rework of adding new roles
…keys when public key is defined
…d store key names
renatav
force-pushed
the
renatav/multiple-yubikeys
branch
3 times, most recently
from
January 29, 2025 23:47
d6d310f
to
de62af3
Compare
renatav
force-pushed
the
renatav/multiple-yubikeys
branch
from
January 29, 2025 23:50
de62af3
to
c98b314
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (e.g. "Related to ...", etc.)
This PR includes several major reworks/new features:
PinManager
class. Instances of this class can be passed into API functions, enabling reuse of already entered pin. Removed all code that stored pins in global dictionaries, as this is less secure.This will allow creation of scripts like this one:
Of course, a PIN should not be specified in this manner when using production YubiKeys. If the PIN manager is empty, the first time a YubiKey is needed, TAF will prompt the user to enter the PIN. The script could also ensure that all PINs are securely entered before calling any of TAF's API functions
Signing after this rework will look like this:
Scenario 1 - no YubiKeys inserted initially, the user inserts one YubiKey first and then the second one later
Scenario 2 - no YubiKeys inserted initially, the users inserts both YubiKeys at the same time:
Here are config files used to create repositories and specify addition of a new role:
keys-description.json
keys-description2.json
keys-description3.json
keys-description4.json
role-config.json
Fix #244
Code review checklist (for code reviewer to complete)