Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CoC Requirements #830

Closed
wants to merge 1 commit into from
Closed

Update CoC Requirements #830

wants to merge 1 commit into from

Conversation

tobie
Copy link
Contributor

@tobie tobie commented Feb 8, 2022 •
edited
Loading

Closes #786.

@tobie tobie marked this pull request as draft February 8, 2022 16:44
@tobie tobie changed the title Update Co Update CoC Requirements Feb 8, 2022
mikesamuel
mikesamuel approved these changes Oct 18, 2022
View reviewed changes
Copy link
Contributor

@mikesamuel mikesamuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Terminology fixes are done consistently. Abbreviations like CoCP are defined before first use and/or are widely used.

mhdawson
mhdawson approved these changes Oct 21, 2022
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Trott
Trott approved these changes Oct 22, 2022
View reviewed changes
Copy link
Contributor

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with or without my suggestion.

@tobie
Copy link
Contributor Author

tobie commented Jan 4, 2023

Closed in favor of ab23997.

@tobie tobie closed this Jan 4, 2023
@ljharb ljharb deleted the tobie-coc-req-updates branch January 4, 2023 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

@Trott Trott Trott approved these changes

@mikesamuel mikesamuel mikesamuel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clarify requirements around CoC violation
4 participants
@tobie @mikesamuel @Trott @mhdawson