Merge pull request #11 from openjournals/rails72

Rails 7.2

Gemfile

@@ -4,7 +4,7 @@ git_source(:github) { |repo| "https://github.com/#{repo}.git" }
 ruby "3.3.3"
 
 # Bundle edge Rails instead: gem "rails", github: "rails/rails", branch: "main"
-gem "rails", "~> 7.1.3"
+gem "rails", "~> 7.2.0"
 # Needed until Ruby 3.3.4 is released https://github.com/ruby/ruby/pull/11006
 gem 'net-pop', github: 'ruby/net-pop'
 

Gemfile.lock

@@ -3,84 +3,81 @@ GIT
  revision: e8d0afe2773b9eb6a23c39e9e437f6fc0fc7c733
  specs:
  net-pop (0.1.2)
+ net-protocol
 
 GEM
  remote: https://rubygems.org/
  specs:
- actioncable (7.1.3.4)
- actionpack (= 7.1.3.4)
- activesupport (= 7.1.3.4)
+ actioncable (7.2.0)
+ actionpack (= 7.2.0)
+ activesupport (= 7.2.0)
  nio4r (~> 2.0)
  websocket-driver (>= 0.6.1)
  zeitwerk (~> 2.6)
- actionmailbox (7.1.3.4)
- actionpack (= 7.1.3.4)
- activejob (= 7.1.3.4)
- activerecord (= 7.1.3.4)
- activestorage (= 7.1.3.4)
- activesupport (= 7.1.3.4)
- mail (>= 2.7.1)
- net-imap
- net-pop
- net-smtp
- actionmailer (7.1.3.4)
- actionpack (= 7.1.3.4)
- actionview (= 7.1.3.4)
- activejob (= 7.1.3.4)
- activesupport (= 7.1.3.4)
- mail (~> 2.5, >= 2.5.4)
- net-imap
- net-pop
- net-smtp
+ actionmailbox (7.2.0)
+ actionpack (= 7.2.0)
+ activejob (= 7.2.0)
+ activerecord (= 7.2.0)
+ activestorage (= 7.2.0)
+ activesupport (= 7.2.0)
+ mail (>= 2.8.0)
+ actionmailer (7.2.0)
+ actionpack (= 7.2.0)
+ actionview (= 7.2.0)
+ activejob (= 7.2.0)
+ activesupport (= 7.2.0)
+ mail (>= 2.8.0)
  rails-dom-testing (~> 2.2)
- actionpack (7.1.3.4)
- actionview (= 7.1.3.4)
- activesupport (= 7.1.3.4)
+ actionpack (7.2.0)
+ actionview (= 7.2.0)
+ activesupport (= 7.2.0)
  nokogiri (>= 1.8.5)
  racc
- rack (>= 2.2.4)
+ rack (>= 2.2.4, < 3.2)
  rack-session (>= 1.0.1)
  rack-test (>= 0.6.3)
  rails-dom-testing (~> 2.2)
  rails-html-sanitizer (~> 1.6)
- actiontext (7.1.3.4)
- actionpack (= 7.1.3.4)
- activerecord (= 7.1.3.4)
- activestorage (= 7.1.3.4)
- activesupport (= 7.1.3.4)
+ useragent (~> 0.16)
+ actiontext (7.2.0)
+ actionpack (= 7.2.0)
+ activerecord (= 7.2.0)
+ activestorage (= 7.2.0)
+ activesupport (= 7.2.0)
  globalid (>= 0.6.0)
  nokogiri (>= 1.8.5)
- actionview (7.1.3.4)
- activesupport (= 7.1.3.4)
+ actionview (7.2.0)
+ activesupport (= 7.2.0)
  builder (~> 3.1)
  erubi (~> 1.11)
  rails-dom-testing (~> 2.2)
  rails-html-sanitizer (~> 1.6)
- activejob (7.1.3.4)
- activesupport (= 7.1.3.4)
+ activejob (7.2.0)
+ activesupport (= 7.2.0)
  globalid (>= 0.3.6)
- activemodel (7.1.3.4)
- activesupport (= 7.1.3.4)
- activerecord (7.1.3.4)
- activemodel (= 7.1.3.4)
- activesupport (= 7.1.3.4)
+ activemodel (7.2.0)
+ activesupport (= 7.2.0)
+ activerecord (7.2.0)
+ activemodel (= 7.2.0)
+ activesupport (= 7.2.0)
  timeout (>= 0.4.0)
- activestorage (7.1.3.4)
- actionpack (= 7.1.3.4)
- activejob (= 7.1.3.4)
- activerecord (= 7.1.3.4)
- activesupport (= 7.1.3.4)
+ activestorage (7.2.0)
+ actionpack (= 7.2.0)
+ activejob (= 7.2.0)
+ activerecord (= 7.2.0)
+ activesupport (= 7.2.0)
  marcel (~> 1.0)
- activesupport (7.1.3.4)
+ activesupport (7.2.0)
  base64
  bigdecimal
- concurrent-ruby (~> 1.0, >= 1.0.2)
+ concurrent-ruby (~> 1.0, >= 1.3.1)
  connection_pool (>= 2.2.5)
  drb
  i18n (>= 1.6, < 2)
+ logger (>= 1.4.2)
  minitest (>= 5.1)
- mutex_m
- tzinfo (~> 2.0)
+ securerandom (>= 0.3)
+ tzinfo (~> 2.0, >= 2.0.5)
  addressable (2.8.7)
  public_suffix (>= 2.0.2, < 7.0)
  base64 (0.2.0)
@@ -98,7 +95,7 @@ GEM
  rack-test (>= 0.6.3)
  regexp_parser (>= 1.5, < 3.0)
  xpath (~> 3.2)
- concurrent-ruby (1.3.3)
+ concurrent-ruby (1.3.4)
  connection_pool (2.4.1)
  crass (1.0.6)
  date (3.3.4)
@@ -129,7 +126,7 @@ GEM
  activesupport (>= 6.0.0)
  railties (>= 6.0.0)
  io-console (0.7.2)
- irb (1.13.2)
+ irb (1.14.0)
  rdoc (>= 4.0.0)
  reline (>= 0.4.2)
  jbuilder (2.12.0)
@@ -161,11 +158,10 @@ GEM
  marcel (1.0.4)
  matrix (0.4.2)
  mini_mime (1.1.5)
- minitest (5.24.0)
+ minitest (5.24.1)
  msgpack (1.7.2)
  multi_xml (0.7.1)
  bigdecimal (~> 3.1)
- mutex_m (0.2.0)
  net-http (0.4.1)
  uri
  net-imap (0.4.14)
@@ -176,17 +172,17 @@ GEM
  net-smtp (0.5.0)
  net-protocol
  nio4r (2.7.3)
- nokogiri (1.16.6-aarch64-linux)
+ nokogiri (1.16.7-aarch64-linux)
  racc (~> 1.4)
- nokogiri (1.16.6-arm-linux)
+ nokogiri (1.16.7-arm-linux)
  racc (~> 1.4)
- nokogiri (1.16.6-arm64-darwin)
+ nokogiri (1.16.7-arm64-darwin)
  racc (~> 1.4)
- nokogiri (1.16.6-x86-linux)
+ nokogiri (1.16.7-x86-linux)
  racc (~> 1.4)
- nokogiri (1.16.6-x86_64-darwin)
+ nokogiri (1.16.7-x86_64-darwin)
  racc (~> 1.4)
- nokogiri (1.16.6-x86_64-linux)
+ nokogiri (1.16.7-x86_64-linux)
  racc (~> 1.4)
  oauth2 (2.0.9)
  faraday (>= 0.17.3, < 3.0)
@@ -220,8 +216,8 @@ GEM
  public_suffix (6.0.0)
  puma (6.4.2)
  nio4r (~> 2.0)
- racc (1.8.0)
- rack (3.1.4)
+ racc (1.8.1)
+ rack (3.1.7)
  rack-protection (4.0.0)
  base64 (>= 0.1.0)
  rack (>= 3.0.0, < 4)
@@ -232,31 +228,31 @@ GEM
  rackup (2.1.0)
  rack (>= 3)
  webrick (~> 1.8)
- rails (7.1.3.4)
- actioncable (= 7.1.3.4)
- actionmailbox (= 7.1.3.4)
- actionmailer (= 7.1.3.4)
- actionpack (= 7.1.3.4)
- actiontext (= 7.1.3.4)
- actionview (= 7.1.3.4)
- activejob (= 7.1.3.4)
- activemodel (= 7.1.3.4)
- activerecord (= 7.1.3.4)
- activestorage (= 7.1.3.4)
- activesupport (= 7.1.3.4)
+ rails (7.2.0)
+ actioncable (= 7.2.0)
+ actionmailbox (= 7.2.0)
+ actionmailer (= 7.2.0)
+ actionpack (= 7.2.0)
+ actiontext (= 7.2.0)
+ actionview (= 7.2.0)
+ activejob (= 7.2.0)
+ activemodel (= 7.2.0)
+ activerecord (= 7.2.0)
+ activestorage (= 7.2.0)
+ activesupport (= 7.2.0)
  bundler (>= 1.15.0)
- railties (= 7.1.3.4)
+ railties (= 7.2.0)
  rails-dom-testing (2.2.0)
  activesupport (>= 5.0.0)
  minitest
  nokogiri (>= 1.6)
  rails-html-sanitizer (1.6.0)
  loofah (~> 2.21)
  nokogiri (~> 1.14)
- railties (7.1.3.4)
- actionpack (= 7.1.3.4)
- activesupport (= 7.1.3.4)
- irb
+ railties (7.2.0)
+ actionpack (= 7.2.0)
+ activesupport (= 7.2.0)
+ irb (~> 1.13)
  rackup (>= 1.0.0)
  rake (>= 12.2)
  thor (~> 1.0, >= 1.2.2)
@@ -295,6 +291,7 @@ GEM
  sawyer (0.9.2)
  addressable (>= 2.3.5)
  faraday (>= 0.17.3, < 3)
+ securerandom (0.3.1)
  selenium-webdriver (4.22.0)
  base64 (~> 0.2)
  logger (~> 1.4)
@@ -336,6 +333,7 @@ GEM
  tzinfo (2.0.6)
  concurrent-ruby (~> 1.0)
  uri (0.13.0)
+ useragent (0.16.10)
  version_gem (1.1.4)
  web-console (4.2.1)
  actionview (>= 6.0.0)
@@ -349,7 +347,7 @@ GEM
  websocket-extensions (0.1.5)
  xpath (3.2.0)
  nokogiri (~> 1.8)
- zeitwerk (2.6.16)
+ zeitwerk (2.6.17)
 
 PLATFORMS
  aarch64-linux
@@ -375,7 +373,7 @@ DEPENDENCIES
  omniauth-rails_csrf_protection
  pg (~> 1.4)
  puma (~> 6.3)
- rails (~> 7.1.3)
+ rails (~> 7.2.0)
  redis (>= 4.0.1)
  rspec-rails (>= 6.0.1)
  selenium-webdriver

bin/brakeman

@@ -0,0 +1,7 @@
+#!/usr/bin/env ruby
+require "rubygems"
+require "bundler/setup"
+
+ARGV.unshift("--ensure-latest")
+
+load Gem.bin_path("brakeman", "brakeman")

bin/setup

@@ -1,8 +1,8 @@
 #!/usr/bin/env ruby
 require "fileutils"
 
-# path to your application root.
 APP_ROOT = File.expand_path("..", __dir__)
+APP_NAME = "reviewers"
 
 def system!(*args)
  system(*args, exception: true)
@@ -30,4 +30,8 @@ FileUtils.chdir APP_ROOT do
 
  puts "\n== Restarting application server =="
  system! "bin/rails restart"
+
+ # puts "\n== Configuring puma-dev =="
+ # system "ln -nfs #{APP_ROOT} ~/.puma-dev/#{APP_NAME}"
+ # system "curl -Is https://#{APP_NAME}.test/up | head -n 1"
 end

config/application.rb

@@ -11,12 +11,12 @@ class Application < Rails::Application
  config.reviewers_settings = config_for(:reviewers_settings)
 
  # Initialize configuration defaults for originally generated Rails version.
- config.load_defaults 7.1
+ config.load_defaults 7.2
 
  # Please, add to the `ignore` list any other `lib` subdirectories that do
  # not contain `.rb` files, or that should not be reloaded or eager loaded.
  # Common ones are `templates`, `generators`, or `middleware`, for example.
- config.autoload_lib(ignore: %w(assets tasks))
+ config.autoload_lib(ignore: %w[assets tasks])
 
  # Configuration for the application, engines, and railties goes here.
  #

config/environments/development.rb

@@ -14,7 +14,7 @@
  # Show full error reports.
  config.consider_all_requests_local = true
 
- # Enable server timing
+ # Enable server timing.
  config.server_timing = true
 
  # Enable/disable caching. By default caching is disabled.
@@ -24,9 +24,7 @@
  config.action_controller.enable_fragment_cache_logging = true
 
  config.cache_store = :memory_store
- config.public_file_server.headers = {
- "Cache-Control" => "public, max-age=#{2.days.to_i}"
- }
+ config.public_file_server.headers = { "Cache-Control" => "public, max-age=#{2.days.to_i}" }
  else
  config.action_controller.perform_caching = false
 
@@ -39,8 +37,12 @@
  # Don't care if the mailer can't send.
  config.action_mailer.raise_delivery_errors = false
 
+ # Disable caching for Action Mailer templates even if Action Controller
+ # caching is enabled.
  config.action_mailer.perform_caching = false
 
+ config.action_mailer.default_url_options = { host: "localhost", port: 3000 }
+
  # Print deprecation notices to the Rails logger.
  config.active_support.deprecation = :log
 
@@ -66,11 +68,14 @@
  # config.i18n.raise_on_missing_translations = true
 
  # Annotate rendered view with file names.
- # config.action_view.annotate_rendered_view_with_filenames = true
+ config.action_view.annotate_rendered_view_with_filenames = true
 
  # Uncomment if you wish to allow Action Cable access from any origin.
  # config.action_cable.disable_request_forgery_protection = true
 
- # Raise error when a before_action's only/except options reference missing actions
+ # Raise error when a before_action's only/except options reference missing actions.
  config.action_controller.raise_on_missing_callback_actions = true
+
+ # Apply autocorrection by RuboCop to files generated by `bin/rails generate`.
+ # config.generators.apply_rubocop_autocorrect_after_generate!
 end