Add undocumented synonym #109
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I got annoyed recently that you assign editors, but you have to add reviewers. In my head, assigning and adding are the same thing. I want a way where you can also assign a reviewer, without having to type another command. This adds that possibility, but it doesn't enforce it for others by documenting or showing it as an option - which might be a good idea. Instead, it just will fall back on adding the user if someone mistakenly uses the word 'assign'.
Let's use only one i.
Member
|
@RichardLitt Thanks! |
xuanxu
reviewed
Apr 25, 2025
Member
xuanxu
left a comment
xuanxu
left a comment
There was a problem hiding this comment.
The code used by JOSS is in the joss branch, not in main
Contributor
Author
|
@xuanxu I wasn't sure where to add it - this was my best guess. Thanks for passing that work forward to where it needs to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got annoyed recently that you assign editors, but you have to add reviewers. In my head, assigning and adding are the same thing.
I want a way where you can also assign a reviewer, without having to type another command. This adds that possibility, but it doesn't enforce it for others by documenting or showing it as an option - which might be a good idea. Instead, it just will fall back on adding the user if someone mistakenly uses the word 'assign'.