Skip to content

Conversation

@liach
Copy link
Member

@liach liach commented Dec 9, 2025

Remove the old Unsafe getValue and putValue, which had some performance difficulties because they are megamorphic depending on the exact layout.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

  • JDK-8373374: [lworld] Remove Unsafe.get/putValue (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1782/head:pull/1782
$ git checkout pull/1782

Update a local copy of the PR:
$ git checkout pull/1782
$ git pull https://git.openjdk.org/valhalla.git pull/1782/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1782

View PR using the GUI difftool:
$ git pr show -t 1782

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1782.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 9, 2025

👋 Welcome back liach! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 9, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title 8373374 8373374: [lworld] Remove Unsafe.get/putValue Dec 9, 2025
@jatin-bhateja
Copy link
Member

jatin-bhateja commented Dec 11, 2025

Removed my comments unrelated to this PR and moved them to following merge PR which has been updated with latest code from lworld
#1688

I plan to conclude this merge by next week, there are some failures, if the code changes are too many then I will open seperate follow up PRs for them instead of adding them with merge.

We don't use Unsafe.putValue/getValue in VectorAPI fallback so removing them looks fine to me.

Best Regards

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 11, 2025
@mlbridge
Copy link

mlbridge bot commented Dec 11, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants