8342992: Security manager check should not use deprecated methods #1627
+81
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As specified in the security manager removal CSR, JDK-8341858, JavaFX now checks at startup whether the security manager is enabled and fails fast with an
UnsupportedOperationException
if it is. The check is currently done in the<clinit>
methods ofPlatformImpl
andLauncherImpl
by calling the deprecatedSystem::getSecurityManager
method.This PR creates a new
SecurityUtility::checkSecurityManager
utility method injavafx.base
that uses reflection to avoid calling API that is deprecated for removal. I also added a call tocheckSecurityManager
inReflectUtil
andMethodUtil
injavafx.base
for non-graphical applications that only usejavafx.base
.Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1627/head:pull/1627
$ git checkout pull/1627
Update a local copy of the PR:
$ git checkout pull/1627
$ git pull https://git.openjdk.org/jfx.git pull/1627/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1627
View PR using the GUI difftool:
$ git pr show -t 1627
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1627.diff
Using Webrev
Link to Webrev Comment