Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8342992: Security manager check should not use deprecated methods #1627

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Nov 5, 2024

As specified in the security manager removal CSR, JDK-8341858, JavaFX now checks at startup whether the security manager is enabled and fails fast with an UnsupportedOperationException if it is. The check is currently done in the <clinit> methods of PlatformImpl and LauncherImpl by calling the deprecated System::getSecurityManager method.

This PR creates a new SecurityUtility::checkSecurityManager utility method in javafx.base that uses reflection to avoid calling API that is deprecated for removal. I also added a call to checkSecurityManager in ReflectUtil and MethodUtil in javafx.base for non-graphical applications that only use javafx.base.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8342992: Security manager check should not use deprecated methods (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1627/head:pull/1627
$ git checkout pull/1627

Update a local copy of the PR:
$ git checkout pull/1627
$ git pull https://git.openjdk.org/jfx.git pull/1627/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1627

View PR using the GUI difftool:
$ git pr show -t 1627

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1627.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 5, 2024

👋 Welcome back kcr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 5, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the rfr Ready for review label Nov 5, 2024
@mlbridge
Copy link

mlbridge bot commented Nov 5, 2024

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rfr Ready for review
Development

Successfully merging this pull request may close these issues.

1 participant