8342459: Remove calls to doPrivileged in javafx.base

[arapte]

Remove doPrivileged calls in the javafx.base module.
The changes are straight forward.

1. Remove doPrivileged calls, with keeping the lambda expression.
2. Remove SuppressWarnings annotations
3. Remove unused imports

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

• JDK-8342459: Remove calls to doPrivileged in javafx.base (Bug - P3)

Reviewers

• Kevin Rushforth (@kevinrushforth - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1625/head:pull/1625
$ git checkout pull/1625

Update a local copy of the PR:
$ git checkout pull/1625
$ git pull https://git.openjdk.org/jfx.git pull/1625/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1625

View PR using the GUI difftool:
$ git pr show -t 1625

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1625.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back arapte! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[mlbridge]

Webrevs

• 01: Full - Incremental (70ebdf94)
• 00: Full (2405da91)

[kevinrushforth]

Pre-submit tests - Linux x64 - Build / test Failing after 3m — 1/1 failed

I just integrated the fix for this, so if you merge in the latest master, you won't see this problem any more.

Reviewers: @kevinrushforth @lukostyra

/reviewers 2

[openjdk]

@kevinrushforth
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

[kevinrushforth]

Looks good. I did leave one inline comment: I think there is a now-unused private AccessControllerContext field in the various *JavaBeans* classes. If so, removing that unused field will also allow removing the remaining SuppressWarnings annotation and the last of the security-related imports.

If you decide to change this I will reapprove. Otherwise, I'll pick it up in the last of the follow-up fixes.

[kevinrushforth]

I think you can remove the now-unused field private final AccessControlContext acc, which will also let you remove the AccessControlContext and AccessController. Alternatively, I will remove them as part of JDK-8342993.

This comment applies to all of the JavaBeanXXXProperty classes.

[arapte]

Thanks Kevin, The variable acc and related 2 imports are now removed in commit.